Re: [PATCH 11/34] kernelshark: Prevent potential divide by zero in Shape::center()

[Yordan Karadzhov <y.karadz@gmail.com>]

On 1/14/24 19:17, Benjamin ROBIN wrote:
> Signed-off-by: Benjamin ROBIN <dev@benjarobin.fr>
> ---
>   src/KsPlotTools.cpp | 14 ++++++++------
>   1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/src/KsPlotTools.cpp b/src/KsPlotTools.cpp
> index 1d63a9b..8011329 100644
> --- a/src/KsPlotTools.cpp
> +++ b/src/KsPlotTools.cpp
> @@ -318,13 +318,15 @@ ksplot_point Shape::center() const
>   {
>   	ksplot_point c = {0, 0};
>   
> -	for (size_t i = 0; i < _nPoints; ++i) {
> -		c.x += _points[i].x;
> -		c.y += _points[i].y;
> -	}
> +	if (_nPoints > 0) {

Can we just have

if (_nPoints == 0)
	return c;


Thanks,
Y.

> +		for (size_t i = 0; i < _nPoints; ++i) {
> +			c.x += _points[i].x;
> +			c.y += _points[i].y;
> +		}
>   
> -	c.x /= _nPoints;
> -	c.y /= _nPoints;
> +		c.x /= _nPoints;
> +		c.y /= _nPoints;
> +	}
>   
>   	return c;
>   }