From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 1/7] kernel-shark-qt: Add plugin infrastructure to be used by the Qt-baset KS.
Date: Thu, 30 Aug 2018 14:45:16 +0300 [thread overview]
Message-ID: <b7b16558-a42f-55d8-7bb1-9f6c868d1897@gmail.com> (raw)
In-Reply-To: <20180829163253.7ba150f5@gandalf.local.home>
On 29.08.2018 23:32, Steven Rostedt wrote:
>> + struct kshark_event_handler **last = handlers;
>> + struct kshark_event_handler *list;
>> +
>> + for (list = *handlers; list; list = list->next) {
> You can simplify this to:
>
> for (last = handlers; *last; last = &(*last)->next) {
> list = *last;
>
>> + if (list->id == event_id &&
>> + list->event_func == evt_func &&
>> + list->draw_func == dw_func) {
>> + *last = list->next;
>> + free(list);
>> + return;
>> + }
>> +
>
>> + last = &list->next;
> Then you can remove the above line.
>
I am confused. For me the two implementations of this for-loop are
identical. Where is the simplification?
Thanks!
Yordan
next prev parent reply other threads:[~2018-08-30 15:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 16:42 [PATCH 0/7] The infrastructure for plugins used by the Qt-based Yordan Karadzhov (VMware)
2018-08-29 16:42 ` [PATCH 1/7] kernel-shark-qt: Add plugin infrastructure to be used by the Qt-baset KS Yordan Karadzhov (VMware)
2018-08-29 20:12 ` Steven Rostedt
2018-08-29 20:17 ` Steven Rostedt
2018-08-29 20:32 ` Steven Rostedt
2018-08-30 11:45 ` Yordan Karadzhov (VMware) [this message]
2018-08-30 16:17 ` Steven Rostedt
2018-08-29 16:42 ` [PATCH 2/7] kernel-shark-qt: Add Plugin event handlers to session Yordan Karadzhov (VMware)
2018-08-30 2:08 ` Steven Rostedt
2018-08-29 16:42 ` [PATCH 3/7] kernel-shark-qt: Add C++/C conversion for args of a plugin draw function Yordan Karadzhov (VMware)
2018-08-29 16:42 ` [PATCH 4/7] kernel-shark-qt: Make kshark_read_at() non-static Yordan Karadzhov (VMware)
2018-08-29 16:42 ` [PATCH 5/7] kernel-shark-qt: Add src/plugins dir. to hold the source code of the plugins Yordan Karadzhov (VMware)
2018-08-29 16:42 ` [PATCH 6/7] kernel-shark-qt: Tell Doxygen to enter ../src/plugins/ Yordan Karadzhov (VMware)
2018-08-29 16:42 ` [PATCH 7/7] kernel-shark-qt: Add a plugin for sched events Yordan Karadzhov (VMware)
2018-08-30 2:43 ` Steven Rostedt
2018-08-30 11:48 ` Yordan Karadzhov (VMware)
2018-08-30 11:49 ` Yordan Karadzhov (VMware)
2018-08-30 14:12 ` Steven Rostedt
2018-08-30 11:51 ` Yordan Karadzhov (VMware)
2018-08-30 14:13 ` Steven Rostedt
2018-08-30 14:50 ` Steven Rostedt
2018-08-30 17:38 ` Steven Rostedt
2018-08-29 16:49 ` [PATCH 0/7] Add infrastructure for plugins Yordan Karadzhov (VMware)
-- strict thread matches above, loose matches on Subject: below --
2018-09-04 15:52 Yordan Karadzhov (VMware)
2018-09-04 15:52 ` [PATCH 1/7] kernel-shark-qt: Add plugin infrastructure to be used by the Qt-baset KS Yordan Karadzhov (VMware)
2018-09-05 2:09 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7b16558-a42f-55d8-7bb1-9f6c868d1897@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).