From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDE9DC433F5 for ; Thu, 17 Feb 2022 16:47:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242796AbiBQQrs (ORCPT ); Thu, 17 Feb 2022 11:47:48 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:38290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239915AbiBQQrr (ORCPT ); Thu, 17 Feb 2022 11:47:47 -0500 X-Greylist: delayed 1205 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 17 Feb 2022 08:47:33 PST Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.51.36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4883C17A8E for ; Thu, 17 Feb 2022 08:47:32 -0800 (PST) Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 0AD0D49C7 for ; Thu, 17 Feb 2022 10:27:18 -0600 (CST) Received: from gator4132.hostgator.com ([192.185.4.144]) by cmsmtp with SMTP id KjcknjH4O22u3Kjcknze4R; Thu, 17 Feb 2022 10:27:18 -0600 X-Authority-Reason: nr=8 Received: from host-95-232-30-176.retail.telecomitalia.it ([95.232.30.176]:34148 helo=[10.0.0.45]) by gator4132.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1nKjcj-003u9J-0E; Thu, 17 Feb 2022 10:27:17 -0600 Message-ID: Date: Thu, 17 Feb 2022 17:27:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [RFC V2 17/21] watchdog/dev: Add tracepoints Content-Language: en-US To: "Peter.Enderborg@sony.com" , Guenter Roeck , Wim Van Sebroeck Cc: Jonathan Corbet , Ingo Molnar , Thomas Gleixner , Peter Zijlstra , Will Deacon , Catalin Marinas , Marco Elver , Dmitry Vyukov , "Paul E. McKenney" , Shuah Khan , Gabriele Paoloni , Juri Lelli , Clark Williams , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-trace-devel@vger.kernel.org" , Steven Rostedt References: <96f418b4-0ba8-01fe-ead0-2028bfc42560@sony.com> From: Daniel Bristot de Oliveira In-Reply-To: <96f418b4-0ba8-01fe-ead0-2028bfc42560@sony.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4132.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - kernel.org X-BWhitelist: no X-Source-IP: 95.232.30.176 X-Source-L: No X-Exim-ID: 1nKjcj-003u9J-0E X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: host-95-232-30-176.retail.telecomitalia.it ([10.0.0.45]) [95.232.30.176]:34148 X-Source-Auth: kernel@bristot.me X-Email-Count: 2 X-Source-Cap: YnJpc3RvdG1lO2JyaXN0b3RtZTtnYXRvcjQxMzIuaG9zdGdhdG9yLmNvbQ== X-Local-Domain: no Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org Hi Peter On 2/16/22 17:01, Peter.Enderborg@sony.com wrote: > On 2/14/22 11:45, Daniel Bristot de Oliveira wrote: >> Add a set of tracepoints, enabling the observability of the watchdog >> device interactions with user-space. >> >> The events are: >> watchdog:watchdog_open >> watchdog:watchdog_close >> watchdog:watchdog_start >> watchdog:watchdog_stop >> watchdog:watchdog_set_timeout >> watchdog:watchdog_ping >> watchdog:watchdog_nowayout >> watchdog:watchdog_set_keep_alive >> watchdog:watchdog_keep_alive > > Some watchdogs have a bark functionality, I think it should be event for that too. > I understand. The problems is that I do not see the bark abstraction in the watchdog_dev layer. In the case I am investigating (the safety_monitor/safety_app) the bark is outside of the "OS" view, it is an hardware action - like. shutdown. Am I missing something? Thoughts? -- Daniel