From: Daniel Bristot de Oliveira <bristot@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@redhat.com>, Tom Zanussi <zanussi@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Juri Lelli <juri.lelli@redhat.com>,
Clark Williams <williams@redhat.com>,
John Kacur <jkacur@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-rt-users@vger.kernel.org,
linux-trace-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 02/19] trace/osnoise: Split workload start from the tracer start
Date: Mon, 25 Oct 2021 09:33:53 +0200 [thread overview]
Message-ID: <be7cbe08-9657-f5ac-4053-0cf2b9c26a78@kernel.org> (raw)
In-Reply-To: <20211022222517.744bbca1@rorschach.local.home>
On 10/23/21 04:25, Steven Rostedt wrote:
> On Thu, 21 Oct 2021 14:56:40 +0200
> Daniel Bristot de Oliveira <bristot@kernel.org> wrote:
>
>> +/*
>> + * osnoise_workload_stop - stop the workload and unhook the events
>> + */
>> +static void osnoise_workload_stop(void)
>> +{
>> + if (!osnoise_busy)
>> + return;
>> +
>> + trace_osnoise_callback_enabled = false;
>
> I know this is just moving this code, but the original code had this
> issue too, but there should be a comment here to why we need the
> compiler barrier.
I will add a comment, like we have on hwlat.
-- Daniel
> -- Steve
>
>
>> + barrier();
>> +
>> + stop_per_cpu_kthreads();
>> +
>> + unhook_irq_events();
>> + unhook_softirq_events();
>> + unhook_thread_events();
>> +
>> + osnoise_busy = false;
>> +}
>> +
next prev parent reply other threads:[~2021-10-25 7:56 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 12:56 [PATCH V4 00/19] RTLA: An interface for osnoise/timerlat tracers Daniel Bristot de Oliveira
2021-10-21 12:56 ` [PATCH V4 01/19] trace/osnoise: Do not follow tracing_cpumask Daniel Bristot de Oliveira
2021-10-23 2:23 ` Steven Rostedt
2021-10-25 7:26 ` Daniel Bristot de Oliveira
2021-10-21 12:56 ` [PATCH V4 02/19] trace/osnoise: Split workload start from the tracer start Daniel Bristot de Oliveira
2021-10-23 2:25 ` Steven Rostedt
2021-10-25 7:33 ` Daniel Bristot de Oliveira [this message]
2021-10-21 12:56 ` [PATCH V4 03/19] trace/osnoise: Use start/stop_per_cpu_kthreads() on osnoise_cpus_write() Daniel Bristot de Oliveira
2021-10-21 12:56 ` [PATCH V4 04/19] trace/osnoise: Support a list of trace_array *tr Daniel Bristot de Oliveira
2021-10-23 2:38 ` Steven Rostedt
2021-10-25 3:26 ` Paul E. McKenney
2021-10-25 9:10 ` Daniel Bristot de Oliveira
2021-10-25 13:35 ` Steven Rostedt
2021-10-25 14:33 ` Paul E. McKenney
2021-10-21 12:56 ` [PATCH V4 05/19] trace/osnoise: Allow multiple instances of the same tracer Daniel Bristot de Oliveira
2021-10-23 2:47 ` Steven Rostedt
2021-10-25 8:08 ` Daniel Bristot de Oliveira
2021-10-25 14:36 ` Steven Rostedt
2021-10-21 12:56 ` [PATCH V4 06/19] rtla: Real-Time Linux Analysis tool Daniel Bristot de Oliveira
2021-10-21 12:56 ` [PATCH V4 07/19] rtla: Helper functions for rtla Daniel Bristot de Oliveira
2021-10-21 12:56 ` [PATCH V4 08/19] rtla: Add osnoise tool Daniel Bristot de Oliveira
2021-10-21 12:56 ` [PATCH V4 09/19] rtla/osnoise: Add osnoise top mode Daniel Bristot de Oliveira
2021-10-21 12:56 ` [PATCH V4 10/19] rtla/osnoise: Add the hist mode Daniel Bristot de Oliveira
2021-10-21 12:56 ` [PATCH V4 11/19] rtla: Add timerlat tool and timelart top mode Daniel Bristot de Oliveira
2021-10-21 12:56 ` [PATCH V4 12/19] rtla/timerlat: Add timerlat hist mode Daniel Bristot de Oliveira
2021-10-21 12:56 ` [PATCH V4 13/19] rtla: Add Documentation Daniel Bristot de Oliveira
2021-10-21 12:56 ` [PATCH V4 14/19] rtla: Add rtla osnoise man page Daniel Bristot de Oliveira
2021-10-21 12:56 ` [PATCH V4 15/19] rtla: Add rtla osnoise top documentation Daniel Bristot de Oliveira
2021-10-21 12:56 ` [PATCH V4 16/19] rtla: Add rtla osnoise hist documentation Daniel Bristot de Oliveira
2021-10-21 12:56 ` [PATCH V4 17/19] rtla: Add rtla timerlat documentation Daniel Bristot de Oliveira
2021-10-21 12:56 ` [PATCH V4 18/19] rtla: Add rtla timerlat top documentation Daniel Bristot de Oliveira
2021-10-21 12:56 ` [PATCH V4 19/19] rtla: Add rtla timerlat hist documentation Daniel Bristot de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be7cbe08-9657-f5ac-4053-0cf2b9c26a78@kernel.org \
--to=bristot@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=jkacur@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).