From: Johannes Berg <johannes@sipsolutions.net>
To: tz.stoyanov@gmail.com, rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] trace-cmd: Do not free pages from the lookup table in struct cpu_data in case trace file is loaded.
Date: Wed, 19 Jun 2019 13:52:14 +0200 [thread overview]
Message-ID: <c456ec4152a3cce13e875666ad080b755a3d39fb.camel@sipsolutions.net> (raw)
In-Reply-To: <20190619114922.3169-1-tz.stoyanov@gmail.com> (sfid-20190619_134925_746058_C0571D59)
On Wed, 2019-06-19 at 14:49 +0300, tz.stoyanov@gmail.com wrote:
> From: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
>
> A major speed regression in trace-cmd v2.8 is reported by Johannes Berg
> when parsing a huge trace.dat file:
>
> "I have a ~1.7G file with just under 620k events (not exactly big by our standards),
> and parsing speed (with -N to disable plugins) goes from ~4.5 seconds on commit
> 1ad32c24746 to >>4.5 minutes (I aborted there) on master.
> I was talking to Steven about another issue, and he pointed me to
> commit c2fc2bc296f7. Reverting that on master makes it take ~2 seconds,
> so that'd actually be an improvement."
>
> Proposed solution: do not free pages from "struct page **pages" lookup table
> in struct cpu_data, in case a trace file is loaded. This reverts the behavior
> for this use case, as it was before commit c2fc2bc296f7.
Seems to work, more or less. I now see ~6.5 seconds which is slower than
it was, and in particular comparing to just a revert (which was ~2
seconds), but it's usable :-)
johannes
next prev parent reply other threads:[~2019-06-19 11:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 11:49 [PATCH] trace-cmd: Do not free pages from the lookup table in struct cpu_data in case trace file is loaded tz.stoyanov
2019-06-19 11:52 ` Johannes Berg [this message]
2019-06-25 22:32 ` Steven Rostedt
2019-06-26 6:51 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c456ec4152a3cce13e875666ad080b755a3d39fb.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).