From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1D4A54670; Mon, 17 Mar 2025 21:19:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742246366; cv=none; b=YXpBbjvpV2xVRHCCOAfsmKXA1ZNHOjmuDg/U5a0gJbdtgXvPmngBWm8CQ2X3Ok2bFlW61TIQDPQRcrUX67jHaV6QOHKI0lkEdTOJEx6DC8cyrsfYyw6d4Kzjb9z93n7hfOCxZ+f4bcWYxSsYsrYAPcV/NjLNtjufN2JKn+Dd8Wk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742246366; c=relaxed/simple; bh=yxOJ65p4SAnE0Ir7dTqcv9g7ATU7SmbWT29NkJuH8BA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=F6igaulZHn5/LwdfhL4NTZlbfb9HFgQcmmjj9YiOVouiDiisX7ZVhvDR6Nfc76G7nulF/fkUEKoWD9qLJs25DpYu4HvVzEa7atW3a+hsN3k9K0YByO/q8k3TqtcGlIvf/b81gthg/KQdj8Hkvc6kWjJAKpAjpe+PP+fueClzkqo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qgUgXRwV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qgUgXRwV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DDFFC4CEE3; Mon, 17 Mar 2025 21:19:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742246366; bh=yxOJ65p4SAnE0Ir7dTqcv9g7ATU7SmbWT29NkJuH8BA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qgUgXRwV69Nt7k3tS39yXyXMdldqU28UP+PtwBMatgfeffOfA5/oHb56jjgdcyxm/ JSGRh83BxwutSnS40H41FN22i3wiENJS/dURZ3QjAjRHXeQG1UMqDT2HVcc79oBvMw vET5PfeOtb2f+b5dq+iwwdVPOK5J+pDe1JXaD9jjDP8DwVr5tpS0ev5oM5mzqDbZnv ai2u9v9ej5kzSJD99oA46h0kZ3R1oPFMxv8UODWo/IX8tL8mkrTsCX3RKrQYklEMUu YO6BRjjTOzO5YIGpehdDeTsx7RuknHnK/zXPyN9Y0IP9bCUcV1+H7bMrAIfj+kVJi4 Oe1CcOBuXZfsg== Message-ID: Date: Mon, 17 Mar 2025 21:19:22 +0000 Precedence: bulk X-Mailing-List: linux-trace-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1 next] tools build: Remove the libunwind feature tests from the ones detected when test-all.o builds To: Ian Rogers , Namhyung Kim Cc: Arnaldo Carvalho de Melo , Adrian Hunter , James Clark , Jiri Olsa , Kan Liang , Linux Kernel Mailing List , linux-perf-users@vger.kernel.org, bpf@vger.kernel.org, linux-trace-devel@vger.kernel.org, Steven Rostedt References: From: Quentin Monnet Content-Language: en-GB In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 2025-03-17 10:16 UTC-0700 ~ Ian Rogers > On Mon, Mar 17, 2025 at 10:06 AM Namhyung Kim wrote: >> >> Hello, >> >> On Mon, Mar 17, 2025 at 09:10:29AM -0700, Ian Rogers wrote: >>> On Wed, Dec 11, 2024 at 7:45 AM Arnaldo Carvalho de Melo >>> wrote: >>>> >>>> We have a tools/build/feature/test-all.c that has the most common set of >>>> features that perf uses and are expected to have its development files >>>> available when building perf. >>>> >>>> When we made libwunwind opt-in we forgot to remove them from the list of >>>> features that are assumed to be available when test-all.c builds, remove >>>> them. >>>> >>>> Before this patch: >>>> >>>> $ rm -rf /tmp/b ; mkdir /tmp/b ; make -C tools/perf O=/tmp/b feature-dump ; grep feature-libunwind-aarch64= /tmp/b/FEATURE-DUMP >>>> feature-libunwind-aarch64=1 >>>> $ >>>> >>>> Even tho this not being test built and those header files being >>>> available: >>>> >>>> $ head -5 tools/build/feature/test-libunwind-aarch64.c >>>> // SPDX-License-Identifier: GPL-2.0 >>>> #include >>>> #include >>>> >>>> extern int UNW_OBJ(dwarf_search_unwind_table) (unw_addr_space_t as, >>>> $ >>>> >>>> After this patch: >>>> >>>> $ grep feature-libunwind- /tmp/b/FEATURE-DUMP >>>> $ >>>> >>>> Now an audit on what is being enabled when test-all.c builds will be >>>> performed. >>>> >>>> Fixes: 176c9d1e6a06f2fa ("tools features: Don't check for libunwind devel files by default") >>>> Cc: Adrian Hunter >>>> Cc: Ian Rogers >>>> Cc: James Clark >>>> Cc: Jiri Olsa >>>> Cc: Kan Liang >>>> Cc: Namhyung Kim >>>> Signed-off-by: Arnaldo Carvalho de Melo >>> >>> Sorry for the delay on this. >>> >>> Reviewed-by: Ian Rogers >> >> Thanks for the review, but I think this part is used by other tools like >> BPF and tracing. It'd be nice to get reviews from them. > > Sgtm. The patch hasn't had attention for 3 months. A quick grep for > "unwind" and "UNW_" shows only use in perf and the feature tests. > > Thanks, > Ian Indeed, bpftool does not rely on libunwind, and I don't remember other BPF components doing so, either. Quentin