Re: [PATCH v2 1/3] kernel-shark: Reorder the priority when searching for trace-cmd libs

["Yordan Karadzhov (VMware)" <y.karadz@gmail.com>]

On 26.03.19 г. 14:58 ч., Steven Rostedt wrote:
> On Wed, 13 Mar 2019 17:22:18 +0200
> Yordan Karadzhov <ykaradzhov@vmware.com> wrote:
> 
>> The CMAKE build system of KernelShark performs automated search for the
>> trace-cmd libraries, headers and executable before building the GUI.
>> The new order of the list of directories to search in is the following:
>>
>> 1. ${TRACE_CMD}/  ($TRACE_CMD is an environment variable)
>>
>> 2. CMAKE_SOURCE_DIR/../
>>
>> 3. Platform / system specific locations
> 
> I'm still confused. We shouldn't be looking for any paths at build time.
> This should be done at run time.
> 
> Now, we can check the local directory that kernelshark lives in. That
> is, if we are running from a fresh build, at start up, we can look at
> 
>   `pwd`/../lib | `pwd`/../../plugins
> 
> and see if those directories exist at run time. And if they do, we can
> use them (as we would assume that the exec is running from a local
> source tree).
> 
> I really don't want any build artifacts in the executable. This will
> mean that you need to do special arrangements to build kernelshark and
> then move it to another machine.

I am confused. I do not know how we can make possible to build 
kernelshark on one machine and then move it to another machine and 
guarantee that it will work. Note that trace-cmd is not the only 
external dependency. We depend on OpenGL, Qt, ....

Qt itself depends on big number of things.

Is this really doable?
Y.

> 
> -- Steve
> 
>>
>> Suggested-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>> Signed-off-by: Yordan Karadzhov <ykaradzhov@vmware.com>
>>