linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org,
	Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
Subject: Re: [PATCH 2/2] kernel-shark-qt: Add Json I/O for filter configurations.
Date: Wed, 8 Aug 2018 14:48:53 +0300	[thread overview]
Message-ID: <ced0da66-0b65-b45b-037a-370fd07a16db@gmail.com> (raw)
In-Reply-To: <20180807212126.0fe0fbe7@gandalf.local.home>


On  8.08.2018 04:21, Steven Rostedt wrote:
>> +
>> +	/* Create a Json array and fill the Id values into it. */
>> +	jfilter_data = json_object_new_array();
>> +	if (!jfilter_data)
> Hmm, can json_object_put() take a NULL pointer?
> 

Yes, see here:

https://github.com/json-c/json-c/blob/master/json_object.c#L185

Thanks!
Yordan

  parent reply	other threads:[~2018-08-08 14:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-07 16:00 [PATCH 1/2] kernel-shark-qt: Add Json-C as a third party dependency Yordan Karadzhov (VMware)
2018-08-07 16:00 ` [PATCH 2/2] kernel-shark-qt: Add Json I/O for filter configurations Yordan Karadzhov (VMware)
2018-08-08  1:21   ` Steven Rostedt
2018-08-08 11:48     ` Yordan Karadzhov (VMware)
2018-08-08 12:32       ` Steven Rostedt
2018-08-08 12:59         ` Yordan Karadzhov (VMware)
2018-08-08 11:48     ` Yordan Karadzhov (VMware) [this message]
2018-08-08 12:33       ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ced0da66-0b65-b45b-037a-370fd07a16db@gmail.com \
    --to=y.karadz@gmail.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tz.stoyanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).