From: Johannes Berg <johannes@sipsolutions.net>
To: Steven Rostedt <rostedt@goodmis.org>,
Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH] trace-cmd record: Verify that splice works before using it
Date: Thu, 19 Jan 2023 22:03:27 +0100 [thread overview]
Message-ID: <d1ab88e414c66197163b80951fcf8639fb3d8f89.camel@sipsolutions.net> (raw)
In-Reply-To: <20220608130527.26e50cba@gandalf.local.home>
On Wed, 2022-06-08 at 13:05 -0400, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
>
> Add a test to make sure that splice works on the source directory before
> using it, and if not automatically switch over to read/write method.
>
> Suggested-by: Johannes Berg <johannes@sipsolutions.net>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=213659
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> ---
> Johannes, can you test this?
> I want to make sure that it fixes the issue.
>
Umm, yeah, long time ago. Sorry, I've been meaning to do that, but it
isn't easy, so I kept pushing it off.
My use case for this was UML with hostfs, which I've since fixed (kernel
upstream commit 1568cb0e6d97 ("hostfs: support splice_write"); I can
revert that easily of course, but then I still have to build my own
trace-cmd with that patch... But that needs libtracefs 1.6 which even
Fedora doesn't ship.
Given that you've merged the patch already, I think I'll just give up on
testing it, sorry about that.
johannes
next prev parent reply other threads:[~2023-01-19 21:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 17:05 [PATCH] trace-cmd record: Verify that splice works before using it Steven Rostedt
2023-01-19 21:03 ` Johannes Berg [this message]
2023-01-19 21:53 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1ab88e414c66197163b80951fcf8639fb3d8f89.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).