From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:55728 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750863AbeFZOvL (ORCPT ); Tue, 26 Jun 2018 10:51:11 -0400 Received: by mail-wm0-f68.google.com with SMTP id v16-v6so2300105wmv.5 for ; Tue, 26 Jun 2018 07:51:11 -0700 (PDT) Subject: Re: [PATCH 5/7] kernel-shark-qt: Add a README file to trace-cmd/kernel-shark-qt To: Steven Rostedt Cc: linux-trace-devel@vger.kernel.org References: <20180625150121.14291-1-y.karadz@gmail.com> <20180625150121.14291-6-y.karadz@gmail.com> <20180625143810.6c1c5189@gandalf.local.home> From: "Yordan Karadzhov (VMware)" Message-ID: Date: Tue, 26 Jun 2018 17:51:07 +0300 MIME-Version: 1.0 In-Reply-To: <20180625143810.6c1c5189@gandalf.local.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-trace-devel-owner@vger.kernel.org List-ID: On 25.06.2018 21:38, Steven Rostedt wrote: > On Mon, 25 Jun 2018 18:01:19 +0300 > "Yordan Karadzhov (VMware)" wrote: > >> +++ b/kernel-shark-qt/README >> @@ -0,0 +1,37 @@ >> + >> +This directory contains the new Qt-based version of the KernelShark GUI. >> + >> + >> +Third Party Software: >> +------------------------------------------------------------ >> +The external dependencies: >> +1. In order to install the packages on Ubuntu do the following: >> + sudo apt-get install build-essential git cmake -y >> + >> +2. In order to install the packages on Fedora, as root do the following: >> + dnf install gcc gcc-c++ git cmake -y > > I'm not so sure how useful this "third party software" section is. I > think it's pretty obvious that gcc, c++ and cmake will be needed. > I would like to have here instructions how to build the code on a default out-of-the-box installation of Ubuntu or Fedora. I agree that it doesn't make sense as it is right now, but it will start making sense when we start adding more and more dependencies. > >> + >> + >> +Building: >> +------------------------------------------------------------ >> +1. Follow the instructions given in trace-cmd/README and build >> +the original trace-cmd end traceevent libraries. >> + >> +2. Do: >> + cd kernel-shark-qt/build >> + cmake ../ >> + make >> + >> +2.1 In order to create a Doxygen documentation add -D_DOXYGEN_DOC=1 >> +as a CMake Command-Line option. >> + cd kernel-shark-qt/build >> + cmake -D_DOXYGEN_DOC=1 ../ >> + make >> + >> +2.2.1 Use "make clean" if you want to delete all already compiled object. >> + >> +2.2.2 Use the script "cmake_clean.sh" if you want to delete all already >> +compiled object and all files generated by CMake. >> + >> +3. After building the code "kernel-shark-qt/lib" will contain all libraries >> +and "kernel-shark-qt/bin" will contain all executables. > > Note, after all the code is in the repo, I expect to have the top level > Makefile, do all the cmake work for the user. > Do you mean, you want to completely remove this README file? Thanks! Yordan > -- Steve >