From: Yordan Karadzhov <y.karadz@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v3] trace-cruncher: Add API to set tracing CPU affinity
Date: Wed, 19 Jan 2022 12:30:39 +0200 [thread overview]
Message-ID: <d429d850-6093-0df5-4c66-f0167b434b79@gmail.com> (raw)
In-Reply-To: <20220118174146.01904fcd@gandalf.local.home>
On 19.01.22 г. 0:41 ч., Steven Rostedt wrote:
> On Tue, 18 Jan 2022 17:40:19 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
>>> I guess you use 'goto err;' everywhere, because you want to stress that returning NULL is essentially exiting with
>>> error. However, so far we used just 'return NULL' everywhere and I would prefer to keep the code consistent.
>>> Maybe in a separate patch we can replace all ''return NULL;' lines with a macro that can have some self-explanatory name?
>>
>> Yeah, I was trying to match the existing code, as I'm new to this. ;-)
>
> Oh, if you haven't noticed. I created a tracefs_instance_get_affinity() API
> as well ;-)
>
> https://patchwork.kernel.org/project/linux-trace-devel/patch/20220118030005.1603821-2-rostedt@goodmis.org/
Great!
Y.
>
> -- Steve
>
next prev parent reply other threads:[~2022-01-19 10:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 1:18 [PATCH v3] trace-cruncher: Add API to set tracing CPU affinity Steven Rostedt
2022-01-18 10:08 ` Yordan Karadzhov
2022-01-18 22:40 ` Steven Rostedt
2022-01-18 22:41 ` Steven Rostedt
2022-01-19 10:30 ` Yordan Karadzhov [this message]
2022-01-19 10:24 ` Yordan Karadzhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d429d850-6093-0df5-4c66-f0167b434b79@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).