From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>,
rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] kernel-shark: Fix search path for libtracefs
Date: Mon, 17 Feb 2020 10:50:35 +0200 [thread overview]
Message-ID: <df514fe1-f068-0cf2-304d-b40fb64b999c@gmail.com> (raw)
In-Reply-To: <20200205070743.13836-1-tz.stoyanov@gmail.com>
On 5.02.20 г. 9:07 ч., Tzvetomir Stoyanov (VMware) wrote:
> Cmake uses wrong relative path while searching for
> development version of libtracefs: lib/trace-cmd,
> but the tracefs library is located at lib/tracefs
>
> Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
> ---
> kernel-shark/build/FindTraceCmd.cmake | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel-shark/build/FindTraceCmd.cmake b/kernel-shark/build/FindTraceCmd.cmake
> index f27fafe..c29b779 100644
> --- a/kernel-shark/build/FindTraceCmd.cmake
> +++ b/kernel-shark/build/FindTraceCmd.cmake
> @@ -43,7 +43,7 @@ find_library(TRACECMD_LIBRARY NAMES trace-cmd/libtracecmd.a
> ${CMAKE_SOURCE_DIR}/../lib/
> NO_DEFAULT_PATH)
>
> -find_library(TRACEFS_LIBRARY NAMES trace-cmd/libtracefs.a
> +find_library(TRACEFS_LIBRARY NAMES tracefs/libtracefs.a
> PATHS $ENV{TRACE_CMD}/lib/
> ${CMAKE_SOURCE_DIR}/../lib/
> NO_DEFAULT_PATH)
>
Hi Ceco,
Thanks for the fix!
Yordan
Fixes: 930ae46d9 (trace-cmd,kernel-shark: Introduce libtracefs library)
Reviewed-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
prev parent reply other threads:[~2020-02-17 8:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 7:07 [PATCH] kernel-shark: Fix search path for libtracefs Tzvetomir Stoyanov (VMware)
2020-02-17 8:50 ` Yordan Karadzhov (VMware) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df514fe1-f068-0cf2-304d-b40fb64b999c@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).