linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 2/3] kernel-shark-qt: Consolidate load_data_entries and load_data_records
Date: Mon, 9 Jul 2018 18:54:54 +0300	[thread overview]
Message-ID: <e2fabd00-4eea-097f-7750-dcc83fcca6ba@gmail.com> (raw)
In-Reply-To: <20180706142440.4d913909@gandalf.local.home>



On  6.07.2018 21:24, Steven Rostedt wrote:
> On Fri, 6 Jul 2018 15:46:54 +0300
> "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
> 
>>> --- trace-cmd.git.orig/kernel-shark-qt/src/libkshark.h
>>> +++ trace-cmd.git/kernel-shark-qt/src/libkshark.h
>>> @@ -33,6 +33,9 @@ extern "C" {
>>>     * info etc.) is available on-demand via the offset into the trace file.
>>>     */
>>>    struct kshark_entry {
>>> +	/** Pointer to the next (in time) kshark_entry on the same CPU core. */
>>> +	struct kshark_entry *next; /* MUST BE FIRST ENTRY */
>>> +
>> Correct, thanks!
> 
> BTW, I was going to ask. Do you use entry->next elsewhere (to get per
> cpu lists)?
> 

Yes, I am using it.

Thanks!
Yordan


> -- Steve
> 

      reply	other threads:[~2018-07-09 15:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-03 16:21 [PATCH 2/3] kernel-shark-qt: Consolidate load_data_entries and load_data_records Steven Rostedt
2018-07-04 11:39 ` Yordan Karadzhov (VMware)
2018-07-05 14:47   ` Steven Rostedt
2018-07-05 14:53     ` Yordan Karadzhov (VMware)
2018-07-05 15:48       ` Steven Rostedt
2018-07-05 16:08   ` Yordan Karadzhov (VMware)
2018-07-05 16:25     ` Steven Rostedt
2018-07-05 16:35   ` Steven Rostedt
2018-07-05 16:38     ` Steven Rostedt
2018-07-05 22:05   ` Steven Rostedt
2018-07-06 10:51     ` Yordan Karadzhov (VMware)
2018-07-06 11:36       ` Yordan Karadzhov (VMware)
2018-07-06 12:46     ` Yordan Karadzhov (VMware)
2018-07-06 18:21       ` Steven Rostedt
2018-07-06 18:43         ` Steven Rostedt
2018-07-09 15:54         ` Yordan Karadzhov (VMware)
2018-07-06 18:24       ` Steven Rostedt
2018-07-09 15:54         ` Yordan Karadzhov (VMware) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2fabd00-4eea-097f-7750-dcc83fcca6ba@gmail.com \
    --to=y.karadz@gmail.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).