linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: linux-trace-devel@vger.kernel.org
Cc: Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v2] libtracefs: add option to disable documentation
Date: Sat, 6 Jan 2024 13:41:12 +0100	[thread overview]
Message-ID: <e5837824-0f3c-4ae5-918e-cf78dd5f3896@benettiengineering.com> (raw)
In-Reply-To: <20230930204008.2528607-1-giulio.benetti@benettiengineering.com>

Hi Steven,

would it be possible to commit this change before releasing new version?
This way I can add both libtracefs and libtraceevent without local
patches as you can see on this iteration to bump trace-cmd:
https://patchwork.ozlabs.org/project/buildroot/list/?series=379077

The same patch has been committed to libtraceevent:
https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/commit/?id=5b893850d20f8e4377dcdf66089d60e2559b4b26

Best regards
-- 
Giulio Benetti
CEO&CTO@Benetti Engineering sas

On 30/09/23 22:40, Giulio Benetti wrote:
> On some Linux environment builder(i.e. Buildroot) host asciidoc is not
> provided since by default all man/docs are not installed to target but
> meson.build at the moment build ascii and html documentation and
> requires asciidoc making the building to fail. So let's add doc option
> set to true by default to let the user to override it and not produce
> the documentation.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * improve commit log as suggested by Steve Rostedt
> ---
>   meson.build       | 3 +++
>   meson_options.txt | 2 ++
>   2 files changed, 5 insertions(+)
> 
> diff --git a/meson.build b/meson.build
> index 9d42d78..f1e492e 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -39,6 +39,8 @@ if cunit_dep.found()
>       subdir('utest')
>   endif
>   subdir('samples')
> +
> +if get_option('doc')
>   subdir('Documentation')
>   
>   custom_target(
> @@ -46,3 +48,4 @@ custom_target(
>       output: 'docs',
>       depends: [html, man],
>       command: ['echo'])
> +endif
> diff --git a/meson_options.txt b/meson_options.txt
> index 1d92c28..5533a88 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -14,3 +14,5 @@ option('man-bold-literal', type : 'boolean', value : false,
>          description : 'enable bold literals')
>   option('docbook-suppress-sp', type : 'boolean', value : false,
>          description : 'docbook suppress sp')
> +option('doc', type : 'boolean', value: true,
> +       description : 'produce documentation')


  reply	other threads:[~2024-01-06 12:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-30 20:40 [PATCH v2] libtracefs: add option to disable documentation Giulio Benetti
2024-01-06 12:41 ` Giulio Benetti [this message]
2024-01-08 19:32   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5837824-0f3c-4ae5-918e-cf78dd5f3896@benettiengineering.com \
    --to=giulio.benetti@benettiengineering.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).