From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v4 2/7] kernel-shark-qt: Add Plugin event handlers to session.
Date: Thu, 20 Sep 2018 16:26:11 +0300 [thread overview]
Message-ID: <e79dde81-68a4-4310-348d-a7da677a5d4d@gmail.com> (raw)
In-Reply-To: <20180919232432.52be5d1b@vmware.local.home>
On 20.09.2018 06:24, Steven Rostedt wrote:
>> /** Special mask used whene filtering events. */
>> KS_EVENT_VIEW_FILTER_MASK = 1 << 2,
>> +
>> + /**
>> + * Use this mask to check if the content of the entry has been accessed
>> + * by a plugin-defined function.
>> + */
>> + KS_PLUGIN_UNTOUCHED_MASK = 1 << 7
> Why the jump to 7?
The "visible" field of the entry will use 8 bits. I know that it is
uint16_t now, but my plan is to use 8 of its bits for the stream_id field.
Currently we use the first 3 bits as different visibility flags and we
have 4 unused bits available for adding more visibility flags in the
future. Because the PLUGIN_UNTOUCHED flag has a different meaning I
decided to place it at the very end.
Is this a problem?
Thanks!
Yordan
next prev parent reply other threads:[~2018-09-20 19:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 14:36 [PATCH v4 0/7] Add infrastructure for plugins Yordan Karadzhov (VMware)
2018-09-19 14:36 ` [PATCH v4 1/7] kernel-shark-qt: Add plugin infrastructure to be used by the Qt-baset KS Yordan Karadzhov (VMware)
2018-09-20 3:13 ` Steven Rostedt
2018-09-19 14:36 ` [PATCH v4 2/7] kernel-shark-qt: Add Plugin event handlers to session Yordan Karadzhov (VMware)
2018-09-20 3:24 ` Steven Rostedt
2018-09-20 13:26 ` Yordan Karadzhov (VMware) [this message]
2018-09-20 13:48 ` Steven Rostedt
2018-09-20 13:29 ` Yordan Karadzhov (VMware)
2018-09-20 13:49 ` Steven Rostedt
2018-09-19 14:36 ` [PATCH v4 3/7] kernel-shark-qt: Add C++/C conversion for args of a plugin draw function Yordan Karadzhov (VMware)
2018-09-19 14:36 ` [PATCH v4 4/7] kernel-shark-qt: Make kshark_read_at() non-static Yordan Karadzhov (VMware)
2018-09-20 3:29 ` Steven Rostedt
2018-09-19 14:36 ` [PATCH v4 5/7] kernel-shark-qt: Add src/plugins dir. to hold the source code of the plugins Yordan Karadzhov (VMware)
2018-09-19 14:36 ` [PATCH v4 6/7] kernel-shark-qt: Tell Doxygen to enter ../src/plugins/ Yordan Karadzhov (VMware)
2018-09-19 14:36 ` [PATCH v4 7/7] kernel-shark-qt: Add a plugin for sched events Yordan Karadzhov (VMware)
2018-09-20 4:11 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e79dde81-68a4-4310-348d-a7da677a5d4d@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).