linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yordan Karadzhov <y.karadz@gmail.com>
To: Andrej Stender <andrej.stender@thermalcircle.de>,
	linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] kernel-shark: Fix function_graph indent monospace
Date: Sat, 8 Oct 2022 18:40:13 +0300	[thread overview]
Message-ID: <e7d94022-bd8e-67dd-0a0e-fcd7eed43f09@gmail.com> (raw)
In-Reply-To: <ce193c5260178313eaaab3dcf49dfcbb9526be0b.1664810553.git.andrej.stender@thermalcircle.de>

Applied. Thanks Andrej!
Yordan


On 10/3/22 18:40, Andrej Stender wrote:
> Show content of KsTraceViewer table in monospaced font. When using
> function_graph tracer, its C-style indentation of traced functions is
> now shown correctly.
> 
> Use system font, so the font used in the table can still can be
> configured via window manager, same as the fonts in title and menus. The
> font in the horizontal header of the table stays regular non-monospaced
> as before.
> 
> Tested on KDE Plasma 5.25.4, Qt 5.15.4.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=216404
> Signed-off-by: Andrej Stender <andrej.stender@thermalcircle.de>
> ---
>   src/KsTraceViewer.cpp | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/src/KsTraceViewer.cpp b/src/KsTraceViewer.cpp
> index afd5a859de72..be0a41941db2 100644
> --- a/src/KsTraceViewer.cpp
> +++ b/src/KsTraceViewer.cpp
> @@ -129,6 +129,9 @@ KsTraceViewer::KsTraceViewer(QWidget *parent)
>   	_view.setSelectionBehavior(QAbstractItemView::SelectRows);
>   	_view.setSelectionMode(QAbstractItemView::SingleSelection);
>   	_view.verticalHeader()->setDefaultSectionSize(FONT_HEIGHT * 1.25);
> +	_view.setFont(QFontDatabase::systemFont(QFontDatabase::FixedFont));
> +	_view.horizontalHeader()->setFont(
> +		QFontDatabase::systemFont(QFontDatabase::GeneralFont));
>   
>   	 _proxyModel.setSource(&_model);
>   	_view.setModel(&_proxyModel);

      reply	other threads:[~2022-10-08 15:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-03 15:40 [PATCH] kernel-shark: Fix function_graph indent monospace Andrej Stender
2022-10-08 15:40 ` Yordan Karadzhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7d94022-bd8e-67dd-0a0e-fcd7eed43f09@gmail.com \
    --to=y.karadz@gmail.com \
    --cc=andrej.stender@thermalcircle.de \
    --cc=linux-trace-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).