Re: [PATCH 2/2] kernel-shark-qt: Add Json I/O for filter configurations.

["Yordan Karadzhov (VMware)" <y.karadz@gmail.com>]

Hi Steven,

On  8.08.2018 04:21, Steven Rostedt wrote:
>> /**
>> + * @brief Create an empty Json document and set its type description.
>> + *
>> + * @param type: String describing the type of the document,
>> + *		e.g. "kshark.record.config" or "kshark.filter.config".
>> + *
>> + * @returns json_object instance. Use json_object_put() to free the object.
> I wonder if we should add handlers like:
> 
> 	kshark_config_free(struct json_object *jobj);
> 
> and call that instead? Perhaps even create our own object that may
> contain extra state that the json object does not, and return that?
> 
> 

What do we gain by doing it this way?

Thanks!
Yordan