From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] kernel-shark-qt: Add I/O for configuration data.
Date: Fri, 17 Aug 2018 18:09:44 +0300 [thread overview]
Message-ID: <f364f502-c14f-b5ee-c4d7-1dc7634ade6d@gmail.com> (raw)
In-Reply-To: <20180817105842.7f14e6e7@gandalf.local.home>
On 17.08.2018 17:58, Steven Rostedt wrote:
> And we can have more than one file saved in the session. Hmm, I wonder
> if we should add code to see if files still exist, and remove the
> information if they do not.
Actually if you use this a lot you may have a big number of *.json files
in your work directory. And some of these files can represent sessions,
some other only filters. But when you click on the Session Import, for
example, the Open File dialog will show you all *.json files. In this
case you may get confused and try to open a wrong file. This is the
reason why we need the "type" field.
Thanks!
Yordan
next prev parent reply other threads:[~2018-08-17 18:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 15:07 [PATCH v3 1/3] kernel-shark-qt: Add Json-C as a third party dependency Yordan Karadzhov (VMware)
2018-08-16 15:07 ` [PATCH v3 2/3] kernel-shark-qt: Add I/O for configuration data Yordan Karadzhov (VMware)
2018-08-16 18:52 ` Steven Rostedt
2018-08-17 9:32 ` Yordan Karadzhov (VMware)
2018-08-17 12:49 ` Steven Rostedt
2018-08-17 14:13 ` Yordan Karadzhov (VMware)
2018-08-17 14:58 ` Steven Rostedt
2018-08-17 15:09 ` Yordan Karadzhov (VMware) [this message]
2018-08-17 15:12 ` Steven Rostedt
2018-08-17 15:29 ` Yordan Karadzhov (VMware)
2018-08-17 15:34 ` Steven Rostedt
2018-08-17 9:34 ` Yordan Karadzhov (VMware)
2018-08-17 12:52 ` Steven Rostedt
2018-08-17 14:15 ` Yordan Karadzhov (VMware)
2018-08-16 15:07 ` [PATCH v3 3/3] kernel-shark-qt: Add an example showing how to import/export config. data Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f364f502-c14f-b5ee-c4d7-1dc7634ade6d@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).