Re: [PATCH 3/4] trace-cruncher: Allow for detachable instances

["Yordan Karadzhov (VMware)" <y.karadz@gmail.com>]

On 23.07.21 г. 0:19, Steven Rostedt wrote:
> On Mon, 12 Jul 2021 15:32:41 +0300
> "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
> 
>> @@ -600,6 +610,11 @@ PyObject *PyFtrace_create_instance(PyObject *self, PyObject *args,
>>   	}
>>   
>>   	iw->ptr = instance;
>> +	if (detached) {
>> +		printf("detached instance: %s\n", name);
> 
> Do we really need to print this? I would think this is up to the
> calling function to print this or not.
>

I think there must be some notice that it is up to the user to take care 
about this new instance. This essentially detaches the instance from the 
garbage collection, which is quite something in the Python world.

Maybe we can change the message with something more appropriate?

Thanks!
Yordan

> -- Steve
> 
> 
>> +		iw->detached = detached;
>> +	}
>> +