From: Daniel Bristot de Oliveira <bristot@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>,
"linux-trace-devel@vger.kernel.org"
<linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH] libtracefs: Add Requires libtraceevent to pkg-config file
Date: Fri, 23 Jul 2021 02:02:57 +0200 [thread overview]
Message-ID: <f7d4e1b4-2cf6-324e-9c8d-838cf841a7ce@redhat.com> (raw)
In-Reply-To: <20210722155435.773e91ec@oasis.local.home>
On 7/22/21 9:54 PM, Steven Rostedt wrote:
> From e0e16d1a16749dccd3c00261e6dcb78f2e55e8ec Mon Sep 17 00:00:00 2001
> From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
> Date: Thu, 22 Jul 2021 15:44:55 -0400
> Subject: [PATCH] libtracefs: Add Requires libtraceevent to pkg-config file
>
> If a developer uses libtracefs only, they should not need to know about
> libtraceevent just because libtracefs requires it.
>
> The pkg-config pc file has an option to handle such cases, called
> "Requires:". Utilize this feature so that users using libtracefs only need
> to do:
>
> CFLAGS = `pkg-config --cflags --libs libtracefs`
>
> And not:
>
> CFLAGS = `pkg-config --cflags --libs libtracefs libtraceevent`
>
> As with the Requires option, pkg-config now produces:
>
> $ pkg-config --cflags --libs libtracefs
> -I/usr/local/include/tracefs -I/usr/local/include/traceevent -ltracefs -ltraceevent
>
> Reported-by: Daniel Bristot de Oliveira <bristot@redhat.com>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
it works!
Tested-by: Daniel Bristot de Oliveira <bristot@redhat.com>
-- Daniel Bristot de Oliveira <bristot@redhat.com>
prev parent reply other threads:[~2021-07-23 0:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 19:54 [PATCH] libtracefs: Add Requires libtraceevent to pkg-config file Steven Rostedt
2021-07-23 0:02 ` Daniel Bristot de Oliveira [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7d4e1b4-2cf6-324e-9c8d-838cf841a7ce@redhat.com \
--to=bristot@redhat.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).