From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6062BC10F14 for ; Tue, 16 Apr 2019 13:32:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 21B9C20870 for ; Tue, 16 Apr 2019 13:32:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=opersys-com.20150623.gappssmtp.com header.i=@opersys-com.20150623.gappssmtp.com header.b="K4yJeduj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728149AbfDPNco (ORCPT ); Tue, 16 Apr 2019 09:32:44 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:35361 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726837AbfDPNco (ORCPT ); Tue, 16 Apr 2019 09:32:44 -0400 Received: by mail-qt1-f196.google.com with SMTP id h39so23270454qte.2 for ; Tue, 16 Apr 2019 06:32:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=opersys-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=odSzkSdVVDMrp1iglvGJ98S0QhuDfS3FFnuPWo+DzR0=; b=K4yJedujazT2+D+W9M8CKJXdHM9f/3FSMY6OheDldEQWbCObFCvm4Lf6AbI8QTSCbq ubogMNCLIohdc6raGbdJjeDzggOf3HizDPVW7OEqVTMwDaXikLuOq3UKF+xhH/jVpBG7 c2FVfY4WOzt/qr0EaKtvmFLYW4iF/b/RWrLIXHBIJiQxvLzfLFVaamkesPNQZJEH+o0S wqCSnzi9E5yObzyn0vk7AFkTt+pQHWJJsiAah5HnAShVVG9LoGp6kD1RUU23vXnkFU23 Ki8czyDVGTxkNqNGQog0ImEXt7+hiinfsqtxwKjdF9vCoq15Py5ThddHvK5+trJCsPIg 24Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=odSzkSdVVDMrp1iglvGJ98S0QhuDfS3FFnuPWo+DzR0=; b=qPZAAWxnE1aUjjpYLs5kPAoVQZ2Wx65HC+ENWeZ09/55pHnKv2nbTGvRjZR4SXx1no o1mu1eB4yI6lannzEyH1j+mSNaJ4gXxCxh+zh/TyBFzeAf+27BMuwwmEtfdPpamAesJT isjnIIjQPYH05K0Y+1LQebe+C/4Y/bpsBXPHzr76wx2dUECJDcjJI9jXGJl61QqEqzim MwXWxiq7I9O/WmWDuojKkS9G14Fg4a5zn0Ov5K4Kq5XbZ/1W1r4TPGf/o5btQQWfIxFR TiXzTr9Koh3kkD2d0IYkvoxzHLH2/VU2UAoKkv/c386rruk+1ZCFEqFZ3GGhHeMVq2yl IAsw== X-Gm-Message-State: APjAAAUwZzi6ma5mO5W5E2j20cA4/7aRrQsA6pCMlXKd5F64qULg+t9y Kj2F0P7JSFu7rP7KaywhM6J/Ag== X-Google-Smtp-Source: APXvYqxD0HykBfgqSujMPqpSlE//rIZ8FZFAlS443Hv16nxhyHBLBDmKI6+MSFoG/v1WhVjthz/R/w== X-Received: by 2002:ac8:1c2c:: with SMTP id a41mr67533327qtk.292.1555421561844; Tue, 16 Apr 2019 06:32:41 -0700 (PDT) Received: from [192.168.202.103] (modemcable170.15-70-69.static.videotron.ca. [69.70.15.170]) by smtp.googlemail.com with ESMTPSA id n41sm37858449qtf.63.2019.04.16.06.32.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Apr 2019 06:32:39 -0700 (PDT) Subject: Re: [PATCH v5 1/3] Provide in-kernel headers to make extending kernel easier To: Joel Fernandes , Greg Kroah-Hartman Cc: Steven Rostedt , Kees Cook , Olof Johansson , Alexei Starovoitov , Joel Fernandes , Linux Kernel Mailing List , Qais Yousef , Dietmar Eggemann , Manoj Rao , Andrew Morton , Alexei Starovoitov , atish patra , Daniel Colascione , Dan Williams , Guenter Roeck , Jonathan Corbet , Android Kernel Team , "open list:DOCUMENTATION" , "open list:KERNEL SELFTEST FRAMEWORK" , linux-trace-devel@vger.kernel.org, Masahiro Yamada , Masami Hiramatsu , Randy Dunlap , Shuah Khan , Yonghong Song References: <20190408203601.GF133872@google.com> <20190411031540.ehezr6kq7ouobpzx@ast-mbp.dhcp.thefacebook.com> <20190415104109.64d914f3@gandalf.local.home> <20190416083306.5646a687@gandalf.local.home> <20190416124939.GB6027@kroah.com> <20190416130440.GA7944@localhost> From: Karim Yaghmour Message-ID: Date: Tue, 16 Apr 2019 09:32:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190416130440.GA7944@localhost> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On 4/16/19 9:04 AM, Joel Fernandes wrote: > On Tue, Apr 16, 2019 at 02:49:39PM +0200, Greg Kroah-Hartman wrote: >> On Tue, Apr 16, 2019 at 08:33:06AM -0400, Steven Rostedt wrote: >>> On Mon, 15 Apr 2019 22:50:10 -0500 >>> Kees Cook wrote: >>> >>>> On Mon, Apr 15, 2019 at 9:41 AM Steven Rostedt wrote: >>>>> I agree with this assessment. We shouldn't use config.gz as precedence >>>>> for this solution. config.gz should have been in debugfs to begin with, >>>>> but I don't believe debugfs was around when config.gz was introduced. >>>>> (Don't have time to look into the history of the two). >>>> >>>> I don't agree with this: /proc/config.gz is used by a lot of tools >>>> that do sanity-check of running systems. This isn't _debugging_... >>>> it's verifying correct kernel builds. It's a fancy version of checking >>>> /proc/version. >>>> >>> >>> Then we should perhaps make a new file system call tarballs ;-) >>> >>> /sys/kernel/tarballs/ >>> >>> and place everything there. That way it removes it from /proc (which is >>> the worse place for that) and also makes it something other than debug. >>> That's what I did for tracefs. >> >> As horrible as that suggestion is, it does kind of make sense :) >> >> We can't put this in debugfs as that's only for debugging and systems >> should never have that mounted for normal operations (users want to >> build ebpf programs), and /proc really should be for processes but that >> horse is long left the barn. >> >> But, I'm willing to consider putting this either in a system-fs-like >> filesystem, or just in sysfs itself, we do have /sys/kernel/ to play >> around in if the main objection is that we should not be cluttering up >> /proc with stuff like this. >> > > I am ok with the suggestion of /sys/kernel for the archive. That also seems > to fit well with the idea that the headers are kernel related and probably > belong here more strictly speaking, than /proc. This makes sense. And if it alleviates concerns regarding extending /proc ABIs then might as well switch to this. Olof, what do you think of this? -- Karim Yaghmour CEO - Opersys inc. / www.opersys.com http://twitter.com/karimyaghmour