From: Andreas Schwab <schwab@suse.de>
To: Daniel Bristot de Oliveira <bristot@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-trace-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] rtla: fix double free
Date: Mon, 25 Jul 2022 15:10:26 +0200 [thread overview]
Message-ID: <mvmzggxl4n1.fsf@suse.de> (raw)
Don't call trace_instance_destroy in trace_instance_init when it fails,
this is done by the caller.
Signed-off-by: Andreas Schwab <schwab@suse.de>
---
tools/tracing/rtla/src/trace.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/tracing/rtla/src/trace.c b/tools/tracing/rtla/src/trace.c
index 5784c9f9e570..7c27fc2a52cb 100644
--- a/tools/tracing/rtla/src/trace.c
+++ b/tools/tracing/rtla/src/trace.c
@@ -179,7 +179,6 @@ int trace_instance_init(struct trace_instance *trace, char *tool_name)
return 0;
out_err:
- trace_instance_destroy(trace);
return 1;
}
--
2.37.1
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next reply other threads:[~2022-07-25 13:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 13:10 Andreas Schwab [this message]
2022-07-25 13:34 ` [PATCH] rtla: fix double free Daniel Bristot de Oliveira
2022-07-25 13:46 ` Andreas Schwab
2022-07-25 14:56 ` Steven Rostedt
2022-07-25 15:12 ` [PATCH v2] rtla: Fix " Andreas Schwab
2022-07-25 15:18 ` Andreas Schwab
2022-07-25 15:23 ` Daniel Bristot de Oliveira
2022-07-25 15:22 ` [PATCH] rtla: fix " Daniel Bristot de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmzggxl4n1.fsf@suse.de \
--to=schwab@suse.de \
--cc=bristot@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).