From: Dan Carpenter <dan.carpenter@linaro.org>
To: Costa Shulyupin <costa.shul@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Daniel Bristot de Oliveira <bristot@kernel.org>,
John Kacur <jkacur@redhat.com>,
"Luis Claudio R. Goncalves" <lgoncalv@redhat.com>,
Eder Zulian <ezulian@redhat.com>,
Tomas Glozar <tglozar@redhat.com>,
Gabriele Monaco <gmonaco@redhat.com>,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] tools/rtla: Add osnoise_trace_is_off()
Date: Wed, 15 Jan 2025 21:40:40 +0300 [thread overview]
Message-ID: <099e9ae9-5d36-46bb-8790-1b6a33dc1448@stanley.mountain> (raw)
In-Reply-To: <20250115180055.2136815-1-costa.shul@redhat.com>
On Wed, Jan 15, 2025 at 07:58:30PM +0200, Costa Shulyupin wrote:
> The original code accidentally works because offset of
> `record->trace` is zero.
It doesn't "accidentally work". The people who write this kind of
code 100% understand what they are doing. They don't see it as
anything complicated.
regards,
dan carpenter
next prev parent reply other threads:[~2025-01-15 18:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 17:58 [PATCH v4] tools/rtla: Add osnoise_trace_is_off() Costa Shulyupin
2025-01-15 18:40 ` Dan Carpenter [this message]
2025-01-17 0:34 ` Steven Rostedt
2025-01-17 5:08 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=099e9ae9-5d36-46bb-8790-1b6a33dc1448@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=bristot@kernel.org \
--cc=costa.shul@redhat.com \
--cc=ezulian@redhat.com \
--cc=gmonaco@redhat.com \
--cc=jkacur@redhat.com \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglozar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox