From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2B0B6364A4; Tue, 9 Jan 2024 11:56:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 209FFC15; Tue, 9 Jan 2024 03:57:01 -0800 (PST) Received: from [192.168.178.6] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 94ED23F64C; Tue, 9 Jan 2024 03:56:10 -0800 (PST) Message-ID: <0a64731f-f6fa-4382-a5cb-a29061eff2d6@arm.com> Date: Tue, 9 Jan 2024 12:56:09 +0100 Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/5] sched: Rename arch_update_thermal_pressure into arch_update_hw_pressure Content-Language: en-US To: Vincent Guittot , linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org, sudeep.holla@arm.com, rafael@kernel.org, viresh.kumar@linaro.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, lukasz.luba@arm.com, rui.zhang@intel.com, mhiramat@kernel.org, daniel.lezcano@linaro.org, amit.kachhap@gmail.com, corbet@lwn.net, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org Cc: qyousef@layalina.io References: <20240108134843.429769-1-vincent.guittot@linaro.org> <20240108134843.429769-5-vincent.guittot@linaro.org> From: Dietmar Eggemann In-Reply-To: <20240108134843.429769-5-vincent.guittot@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 08/01/2024 14:48, Vincent Guittot wrote: > Now that cpufreq provides a pressure value to the scheduler, rename I.e. that thermal (e.g. IPA governor) switches from average (rq->avg_(thermal/hw).load_avg) (1) to instantenous (cpu_pressure) (2). I rememeber a related dicussion during LPC 2018 :-) > arch_update_thermal_pressure into HW pressure to reflect that it returns > a pressure applied by HW (i.e. with a high frequency change) and not > always related to thermal mitigation but also generated by max current > limitation as an example. Such high frequency signal needs filtering to be > smoothed and provide an value that reflects the average available capacity > into the scheduler time scale. So 'drivers/cpufreq/qcom-cpufreq-hw.c' is the only user of (1) right now. Are we expecting more users here? If this stays the only user, maybe it can do the averages by itself and we can completely switch to (2)? [...]