From: David Hildenbrand <david@redhat.com>
To: schuster.simon@siemens-energy.com,
Steven Rostedt <rostedt@goodmis.org>,
Christian Brauner <brauner@kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] rv/ltl_monitor: adapt handle_task_newtask to u64 clone_flags
Date: Wed, 10 Sep 2025 10:05:31 +0200 [thread overview]
Message-ID: <0b1fb5c2-3d36-4fa4-95b0-02c693933228@redhat.com> (raw)
In-Reply-To: <20250904-trace-task-newtask-fix-callbacks-v1-1-8edb3d557365@siemens-energy.com>
On 04.09.25 13:36, Simon Schuster via B4 Relay wrote:
> From: Simon Schuster <schuster.simon@siemens-energy.com>
>
> Since commit edd3cb05c00a ("copy_process: pass clone_flags as u64 across
> calltree") the task_newtask trace event exposes clone_flags as u64 to
> its callbacks.
>
> However, ltl_monitor was not adapted, resulting in a faulty callback.
> This also resulted in an lkp build warning due to
> -Wincompatible-pointer-types.
>
> Fixes: edd3cb05c00a ("copy_process: pass clone_flags as u64 across calltree")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/lkml/20250904113334.18822d43@canb.auug.org.au/
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202509040134.bQVbm7ja-lkp@intel.com/
> Signed-off-by: Simon Schuster <schuster.simon@siemens-energy.com>
> ---
> I did further search for other in-tree users of the task_newtask
> callback, but the trace macros make it a bit harder. Yet, as far as I
> could see, there are none, so this patch hopefully resolves the problem
> for good. The other matches all relate to "tp_btf/task_newtask", which
> seems to be unaffected.
>
> With this patch, ARCH=S390 allmodconfig -- that originally tripped the
> LKP builds -- now builds without further -Wincompatible-pointer-types
> warnings.
>
> Sorry for causing this trouble, and thanks to Stephen Rothwell for
> testing/reporting.
> ---
Not a stable commit id I think, so it should be squashed into the
original one.
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers
David / dhildenb
next prev parent reply other threads:[~2025-09-10 8:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 11:36 [PATCH] rv/ltl_monitor: adapt handle_task_newtask to u64 clone_flags Simon Schuster via B4 Relay
2025-09-09 11:06 ` Gabriele Monaco
2025-09-10 7:43 ` Nam Cao
2025-09-10 8:05 ` David Hildenbrand [this message]
2025-09-15 14:37 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b1fb5c2-3d36-4fa4-95b0-02c693933228@redhat.com \
--to=david@redhat.com \
--cc=arnd@arndb.de \
--cc=brauner@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lorenzo.stoakes@oracle.com \
--cc=rostedt@goodmis.org \
--cc=schuster.simon@siemens-energy.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox