Re: [PATCH v2 3/5] verification/rvgen/ltl: Support per-cpu monitor generation

[Gabriele Monaco <gmonaco@redhat.com>]

On Fri, 2025-08-08 at 07:12 +0200, Nam Cao wrote:
> Gabriele Monaco <gmonaco@redhat.com> writes:
> > I get you're trying to be more type-agnostic, but I believe this
> > /online/ is a bit imprecise, unless you register a hotplug handler
> > and just initialise the online CPUs (much of an overkill I'd say).
> > What about something like "this is false if the monitor exists
> > already before the monitor is enabled"
> 
> Sorry, after re-reading this one day later, I am still not sure why
> you says "online" is imprecise. Due to hotplug, CPUs can become
> online and offline.
> 
> The current implementation ignore hotplug and initialize all possible
> CPUs as if they are all oneline. But if hotplug becomes important in
> the future, I may add a CPU hotplug handler.

Alright, I was probably a bit unclear with that, I don't mean the
implementation needs changes, only the wording.

> This is false if the monitor target is already online before the
> monitor is enabled.

becomes

> This is false if the CPU is already online before the monitor is
> enabled.

which is not always true, when starting the monitor, you initialise all
possible CPUs, also offline ones, which are still initialised with
@target_creation as false.

Mind I don't say you should change the value passed to ltl_target_init
nor change your logic, I only mean /online/ isn't the right word here.

Does this make more sense?

Thanks,
Gabriele