From: Daniel Bristot de Oliveira <bristot@kernel.org>
To: Yu Liao <liaoyu15@huawei.com>, rostedt@goodmis.org
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
liwei391@huawei.com
Subject: Re: [PATCH -next v2] rv/include: set variable 'da_mon_##name' to static
Date: Fri, 25 Aug 2023 15:25:09 +0200 [thread overview]
Message-ID: <0f2be47c-7c35-ec64-7eba-41fdc49af8ca@kernel.org> (raw)
In-Reply-To: <20230823020051.3184953-1-liaoyu15@huawei.com>
On 8/23/23 04:00, Yu Liao wrote:
> gcc with W=1 reports
> kernel/trace/rv/monitors/wip/wip.c:20:1: sparse: sparse: symbol 'da_mon_wip' was not declared. Should it be static?
>
> The per-cpu variable 'da_mon_##name' is only used in its defining file, so
> it should be static.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307280030.7EjUG9gR-lkp@intel.com/
> Signed-off-by: Yu Liao <liaoyu15@huawei.com>
Acked-by: Daniel Bristot de Oliveira <bristot@kernel.org>
Thanks!
-- Daniel
prev parent reply other threads:[~2023-08-25 13:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 2:00 [PATCH -next v2] rv/include: set variable 'da_mon_##name' to static Yu Liao
2023-08-25 13:25 ` Daniel Bristot de Oliveira [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f2be47c-7c35-ec64-7eba-41fdc49af8ca@kernel.org \
--to=bristot@kernel.org \
--cc=liaoyu15@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).