From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Question about config UPROBES and UPROBE_EVENTS
Date: Tue, 1 Oct 2024 14:30:33 +0800 [thread overview]
Message-ID: <10d33d7f-5785-93e1-128d-5ad6ac2e771f@loongson.cn> (raw)
In-Reply-To: <20241001004307.bc238bbda81907c08a8c1e96@kernel.org>
On 9/30/24 23:43, Masami Hiramatsu (Google) wrote:
> On Mon, 30 Sep 2024 11:32:31 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
>> On Tue, 1 Oct 2024 00:28:13 +0900
>> Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
>>
>>> On Mon, 30 Sep 2024 10:06:30 -0400
>>> Steven Rostedt <rostedt@goodmis.org> wrote:
>>>
>>>> On Mon, 30 Sep 2024 09:33:42 +0800
>>>> Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
>>>>
>>>>>> the CONFIG_UPROBES is disabled by default and make CONFIG_UPROBE_EVENTS
>>>>>> depending on it, the uprobe_events menu is hidden. I don't like this.
>>>>>
>>>>> This is somehow like the current status of CONFIG_KPROBES and
>>>>> CONFIG_KPROBE_EVENTS.
>>>>
>>>> The question is, can uprobes be used without uprobe_events? With the
>>>> current BPF work that I haven't been following, it may be possible now.
>>>
>>> uprobe_register/unregister APIs are exposed to the kernel modules,
>>> since systemtap had been introduced this feature.
>>>
>>
>> OK, but since they have always been visible, I would just make
>> CONFIG_UPROBES a normal option and CONFIG_UPROBE_EVENTS select it if it
>> gets selected, and not depend on it.
>
> Agreed.
Thanks very much for your discussions. I agree with you.
Then, CONFIG_KPROBE_EVENTS should depend on or select CONFIG_KPROBES?
In the current code, CONFIG_KPROBE_EVENTS depend on CONFIG_KPROBES,
the CONFIG_KPROBE_EVENTS menu is hidden if CONFIG_KPROBES is not set.
Thanks,
Tiezhu
next prev parent reply other threads:[~2024-10-01 6:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 6:40 Question about config UPROBES and UPROBE_EVENTS Tiezhu Yang
2024-09-11 13:43 ` Steven Rostedt
2024-09-29 23:15 ` Masami Hiramatsu
2024-09-30 1:33 ` Tiezhu Yang
2024-09-30 14:06 ` Steven Rostedt
2024-09-30 15:28 ` Masami Hiramatsu
2024-09-30 15:32 ` Steven Rostedt
2024-09-30 15:43 ` Masami Hiramatsu
2024-10-01 6:30 ` Tiezhu Yang [this message]
2024-10-01 12:30 ` Steven Rostedt
2024-10-01 12:33 ` Steven Rostedt
2024-10-01 12:32 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10d33d7f-5785-93e1-128d-5ad6ac2e771f@loongson.cn \
--to=yangtiezhu@loongson.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).