linux-trace-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Francis Laniel <flaniel@linux.microsoft.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/1] tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols
Date: Wed, 18 Oct 2023 17:43:36 +0300	[thread overview]
Message-ID: <12305596.O9o76ZdvQC@pwmachine> (raw)
In-Reply-To: <20231018153020.fac28cf4381b57e179104b02@kernel.org>

Hi!

Le mercredi 18 octobre 2023, 09:30:20 EEST Masami Hiramatsu a écrit :
> Hi Francis,
> 
> On Thu, 31 Aug 2023 09:14:55 +0200
> 
> Francis Laniel <flaniel@linux.microsoft.com> wrote:
> > Hi.
> > 
> > Le mercredi 30 août 2023, 01:57:19 CEST Steven Rostedt a écrit :
> > > On Fri, 25 Aug 2023 22:13:21 +0900
> > > 
> > > Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> > > > > Excellent catch! Thank you, I will apply this patch and send v4
> > > > > right
> > > > > after. Regarding test, do you think I can add a test for the
> > > > > EADDRNOTAVAIL case?>
> > > > 
> > > > Hmm, in that case, you need to change something in tracefs/README so
> > > > that
> > > > we can identify the kernel has different behavior. Or we have to
> > > > change
> > > > this is a "Fix" for backporting.
> > > 
> > > I prefer this to be a Fix and backported.
> > 
> > This makes sense, I will send v5 to stable mailing list too!
> 
> I missed this a while. did you send v5 ? I could not find in my mbox.

Sorry, I took a bit of time before sending the v5 as I wanted to wait for 
Alessandro patchset to be merged first.
As it seems more work is needed on his contribution I think we can go with 
this fix first.

> Thank you,
> 
> > > Thanks,
> > > 
> > > -- Steve
> > 
> > Best regards.

Best regards.



      reply	other threads:[~2023-10-18 14:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-24 16:08 [PATCH v3 0/1] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation Francis Laniel
2023-08-24 16:08 ` [PATCH v3 1/1] tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols Francis Laniel
2023-08-25  2:46   ` Masami Hiramatsu
2023-08-25 12:16   ` Masami Hiramatsu
2023-08-25 12:34     ` Francis Laniel
2023-08-25 13:13       ` Masami Hiramatsu
2023-08-25 14:14         ` Francis Laniel
2023-08-29 23:57         ` Steven Rostedt
2023-08-31  7:14           ` Francis Laniel
2023-10-18  6:30             ` Masami Hiramatsu
2023-10-18 14:43               ` Francis Laniel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12305596.O9o76ZdvQC@pwmachine \
    --to=flaniel@linux.microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).