From: SUVONOV BUNYOD <b.suvonov@sjtu.edu.cn>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: akpm <akpm@linux-foundation.org>, vbabka <vbabka@kernel.org>,
linux-mm <linux-mm@kvack.org>, mhiramat <mhiramat@kernel.org>,
mathieu desnoyers <mathieu.desnoyers@efficios.com>,
linux-trace-kernel <linux-trace-kernel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
surenb <surenb@google.com>, mhocko <mhocko@suse.com>,
jackmanb <jackmanb@google.com>, hannes <hannes@cmpxchg.org>,
ziy <ziy@nvidia.com>, david <david@kernel.org>,
vishal moola <vishal.moola@gmail.com>, corbet <corbet@lwn.net>,
skhan <skhan@linuxfoundation.org>,
linux-doc <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v2] mm/page_alloc: trace PCP refills and PCP zone lock usage
Date: Wed, 29 Apr 2026 11:31:53 +0800 (CST) [thread overview]
Message-ID: <1453063691.2584758.1777433513691.JavaMail.zimbra@sjtu.edu.cn> (raw)
In-Reply-To: <20260428142335.3bca0166@gandalf.local.home>
Thanks for reviewing Steven,
>Why this change? It makes it much harder to understand.
>
>The above is not a normal macro. Ignore any checkpatch warnings about it.
>The proper way to do the TP_STRUCT__entry() is to make it just like a struct:
>
>struct {
> unsigned long pfn;
> unsigned int order;
> int migratetype;
>};
>
>Thus, the macro should be:
>
> TP_STRUCT__entry(
> __field( unsigned long, pfn )
> __field( unsigned int, order )
> __field( int, migratetype )
> ),
Yeah sorry for the formatting issue, will fix in v3. Any other concerns?
What do you think about the introduction of those tracepoints themselves?
-- Bunyod
next prev parent reply other threads:[~2026-04-29 3:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-25 9:13 [PATCH] mm/page_alloc: add tracepoint for PCP refills Bunyod Suvonov
2026-04-26 22:06 ` Vishal Moola
2026-04-27 6:01 ` [PATCH v2] mm/page_alloc: trace PCP refills and PCP zone lock usage Bunyod Suvonov
2026-04-27 6:21 ` SUVONOV BUNYOD
2026-04-28 18:23 ` Steven Rostedt
2026-04-29 3:31 ` SUVONOV BUNYOD [this message]
2026-04-29 14:52 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453063691.2584758.1777433513691.JavaMail.zimbra@sjtu.edu.cn \
--to=b.suvonov@sjtu.edu.cn \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mhocko@suse.com \
--cc=rostedt@goodmis.org \
--cc=skhan@linuxfoundation.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=vishal.moola@gmail.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox