linux-trace-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
To: linux-trace-kernel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	mhiramat@kernel.org, Martin KaFai Lau <martin.lau@linux.dev>,
	bpf@vger.kernel.org, Sven Schnelle <svens@linux.ibm.com>,
	Alexei Starovoitov <ast@kernel.org>
Subject: [PATCH v2 8/9] selftests/ftrace: Add BTF fields access testcases
Date: Tue, 18 Jul 2023 00:24:37 +0900	[thread overview]
Message-ID: <168960747750.34107.6104527579648222887.stgit@devnote2> (raw)
In-Reply-To: <168960739768.34107.15145201749042174448.stgit@devnote2>

From: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Add test cases for accessing the data structure fields using BTF info.
This includes the field access from parameters and retval, and accessing
string information.

Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
---
Changes in v2:
 - Use '$retval' instead of 'retval'.
 - Add a test that use both '$retval' and '$arg1' for fprobe.
---
 .../ftrace/test.d/dynevent/add_remove_btfarg.tc    |   11 +++++++++++
 .../ftrace/test.d/dynevent/fprobe_syntax_errors.tc |    4 ++++
 2 files changed, 15 insertions(+)

diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_btfarg.tc b/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_btfarg.tc
index b89de1771655..93b94468967b 100644
--- a/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_btfarg.tc
+++ b/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_btfarg.tc
@@ -21,6 +21,8 @@ echo 0 > events/enable
 echo > dynamic_events
 
 TP=kfree
+TP2=kmem_cache_alloc
+TP3=getname_flags
 
 if [ "$FPROBES" ] ; then
 echo "f:fpevent $TP object" >> dynamic_events
@@ -33,6 +35,7 @@ echo > dynamic_events
 
 echo "f:fpevent $TP "'$arg1' >> dynamic_events
 grep -q "fpevent.*object=object" dynamic_events
+
 echo > dynamic_events
 
 echo "f:fpevent $TP "'$arg*' >> dynamic_events
@@ -45,6 +48,14 @@ fi
 
 echo > dynamic_events
 
+echo "t:tpevent $TP2 name=s->name:string" >> dynamic_events
+echo "f:fpevent ${TP3}%return path=\$retval->name:string" >> dynamic_events
+
+grep -q "tpevent.*name=s->name:string" dynamic_events
+grep -q "fpevent.*path=\$retval->name:string" dynamic_events
+
+echo > dynamic_events
+
 if [ "$KPROBES" ] ; then
 echo "p:kpevent $TP object" >> dynamic_events
 grep -q "kpevent.*object=object" dynamic_events
diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc b/tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc
index 72563b2e0812..49758f77c923 100644
--- a/tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc
+++ b/tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc
@@ -103,6 +103,10 @@ check_error 'f vfs_read%return ^$arg*'		# NOFENTRY_ARGS
 check_error 'f vfs_read ^hoge'			# NO_BTFARG
 check_error 'f kfree ^$arg10'			# NO_BTFARG (exceed the number of parameters)
 check_error 'f kfree%return ^$retval'		# NO_RETVAL
+check_error 'f vfs_read%return $retval->^foo'	# NO_PTR_STRCT
+check_error 'f vfs_read file->^foo'		# NO_BTF_FIELD
+check_error 'f vfs_read file^-.foo'		# BAD_HYPHEN
+check_error 'f vfs_read ^file:string'		# BAD_TYPE4STR
 else
 check_error 'f vfs_read ^$arg*'			# NOSUP_BTFARG
 check_error 't kfree ^$arg*'			# NOSUP_BTFARG


  parent reply	other threads:[~2023-07-17 15:25 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-17 15:23 [PATCH v2 0/9] tracing: Improbe BTF support on probe events Masami Hiramatsu (Google)
2023-07-17 15:23 ` [PATCH v2 1/9] tracing/probes: Fix to add NULL check for BTF APIs Masami Hiramatsu (Google)
2023-07-17 15:23 ` [PATCH v2 2/9] bpf/btf: tracing: Move finding func-proto API and getting func-param API to BTF Masami Hiramatsu (Google)
2023-07-17 18:39   ` Steven Rostedt
2023-07-17 23:46     ` Masami Hiramatsu
2023-07-17 23:51       ` Alexei Starovoitov
2023-07-18  1:03         ` Masami Hiramatsu
2023-07-17 23:51       ` Steven Rostedt
2023-07-18  1:02         ` Masami Hiramatsu
2023-07-18  2:40   ` Donglin Peng
2023-07-18 10:44     ` Masami Hiramatsu
2023-07-18 13:56       ` Masami Hiramatsu
2023-07-18 17:11         ` Alexei Starovoitov
2023-07-18 23:03           ` Masami Hiramatsu
2023-07-18 23:12             ` Alexei Starovoitov
2023-07-19 15:17               ` Masami Hiramatsu
2023-07-19  2:09             ` Donglin Peng
2023-07-19 15:15               ` Masami Hiramatsu
2023-07-19 12:36   ` Alan Maguire
2023-07-19 15:24     ` Masami Hiramatsu
2023-07-19 15:49       ` Alan Maguire
2023-07-17 15:23 ` [PATCH v2 3/9] bpf/btf: Add a function to search a member of a struct/union Masami Hiramatsu (Google)
2023-07-20 22:34   ` Alan Maguire
2023-07-21 14:22     ` Masami Hiramatsu
2023-07-17 15:23 ` [PATCH v2 4/9] tracing/probes: Support BTF based data structure field access Masami Hiramatsu (Google)
2023-07-20 22:51   ` Alan Maguire
2023-07-21 14:22     ` Masami Hiramatsu
2023-07-17 15:24 ` [PATCH v2 5/9] tracing/probes: Support BTF field access from $retval Masami Hiramatsu (Google)
2023-07-17 15:24 ` [PATCH v2 6/9] tracing/probes: Add string type check with BTF Masami Hiramatsu (Google)
2023-07-17 15:24 ` [PATCH v2 7/9] tracing/fprobe-event: Assume fprobe is a return event by $retval Masami Hiramatsu (Google)
2023-07-17 15:24 ` Masami Hiramatsu (Google) [this message]
2023-07-20 23:00   ` [PATCH v2 8/9] selftests/ftrace: Add BTF fields access testcases Alan Maguire
2023-07-21  1:42     ` Masami Hiramatsu
2023-07-17 15:24 ` [PATCH v2 9/9] Documentation: tracing: Update fprobe event example with BTF field Masami Hiramatsu (Google)
2023-07-20 22:53   ` Alan Maguire
2023-07-21 13:58     ` Masami Hiramatsu
2023-07-19  9:02 ` [PATCH v2 0/9] tracing: Improbe BTF support on probe events Alan Maguire
2023-07-19 16:01   ` Masami Hiramatsu
2023-07-20 21:50     ` Alan Maguire
2023-07-25 23:45       ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=168960747750.34107.6104527579648222887.stgit@devnote2 \
    --to=mhiramat@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=rostedt@goodmis.org \
    --cc=svens@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).