From: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Florent Revest <revest@chromium.org>
Cc: linux-trace-kernel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
bpf <bpf@vger.kernel.org>, Sven Schnelle <svens@linux.ibm.com>,
Alexei Starovoitov <ast@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Alan Maguire <alan.maguire@oracle.com>,
Mark Rutland <mark.rutland@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [RFC PATCH v2 0/6] bpf: fprobe: rethook: Use ftrace_regs instead of pt_regs
Date: Mon, 7 Aug 2023 15:48:24 +0900 [thread overview]
Message-ID: <169139090386.324433.6412259486776991296.stgit@devnote2> (raw)
Hi,
Here is the 2nd version of RFC series to use ftrace_regs instead of pt_regs.
But this includes the generic part and minimum modifications of arch
dependent code. (e.g. not including rethook for arm64.) This series is based
on the discussion at
https://lore.kernel.org/all/20230801112036.0d4ee60d@gandalf.local.home/
This version includes 1 patch to expose ftrace_regs. so
- Simply replace pt_regs in fprobe_entry_handler with ftrace_regs.
- Expose ftrace_regs even if CONFIG_FUNCTION_TRACER=n.
- Replace pt_regs in rethook and fprobe_exit_handler with ftrace_regs. This
introduce a new HAVE_PT_REGS_COMPAT_FTRACE_REGS which means ftrace_regs is
just a wrapper of pt_regs (except for arm64, other architectures do this)
- Update fprobe-events to use ftrace_regs natively.
- Introduce ftrace_partial_regs(). (This changes ARM64 which needs a custom
implementation)
- Update bpf multi-kprobe handler use ftrace_partial_regs().
Florent, feel free to add your rethook for arm64, but please do not remove
kretprobe trampoline yet. It is another discussion point. We may be possible
to use ftrace_regs for kretprobe by ftrace_partial_regs() but kretprobe
allows nest probe. (maybe we can skip that case?)
This series can also be found below branch.
https://git.kernel.org/pub/scm/linux/kernel/git/mhiramat/linux.git/log/?h=topic/fprobe-ftrace-regs
Thank you,
---
Masami Hiramatsu (Google) (6):
fprobe: Use fprobe_regs in fprobe entry handler
tracing: Expose ftrace_regs regardless of CONFIG_FUNCTION_TRACER
fprobe: rethook: Use fprobe_regs in fprobe exit handler and rethook
tracing/fprobe: Enable fprobe events with CONFIG_DYNAMIC_FTRACE_WITH_ARGS
ftrace: Add ftrace_partial_regs() for converting ftrace_regs to pt_regs
bpf: Enable kprobe_multi feature if CONFIG_FPROBE is enabled
arch/Kconfig | 1 +
arch/arm64/include/asm/ftrace.h | 11 ++++++
arch/loongarch/Kconfig | 1 +
arch/s390/Kconfig | 1 +
arch/x86/Kconfig | 1 +
arch/x86/kernel/rethook.c | 9 +++--
include/linux/fprobe.h | 4 +-
include/linux/ftrace.h | 56 ++++++++++++++++++-----------
include/linux/rethook.h | 11 +++---
kernel/kprobes.c | 9 ++++-
kernel/trace/Kconfig | 9 ++++-
kernel/trace/bpf_trace.c | 14 +++++--
kernel/trace/fprobe.c | 8 ++--
kernel/trace/rethook.c | 16 ++++----
kernel/trace/trace_fprobe.c | 76 ++++++++++++++++++++++++---------------
kernel/trace/trace_probe_tmpl.h | 2 +
lib/test_fprobe.c | 10 +++--
samples/fprobe/fprobe_example.c | 4 +-
18 files changed, 154 insertions(+), 89 deletions(-)
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next reply other threads:[~2023-08-07 6:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 6:48 Masami Hiramatsu (Google) [this message]
2023-08-07 6:48 ` [RFC PATCH v2 1/6] fprobe: Use fprobe_regs in fprobe entry handler Masami Hiramatsu (Google)
2023-08-09 10:28 ` Florent Revest
2023-08-09 14:10 ` Masami Hiramatsu
2023-08-09 16:09 ` Florent Revest
2023-08-09 16:17 ` Florent Revest
2023-08-09 22:13 ` Masami Hiramatsu
2023-08-11 17:10 ` Steven Rostedt
2023-08-07 6:48 ` [RFC PATCH v2 2/6] tracing: Expose ftrace_regs regardless of CONFIG_FUNCTION_TRACER Masami Hiramatsu (Google)
2023-08-09 10:29 ` Florent Revest
2023-08-09 14:16 ` Masami Hiramatsu
2023-08-09 15:53 ` Florent Revest
2023-08-07 6:48 ` [RFC PATCH v2 3/6] fprobe: rethook: Use fprobe_regs in fprobe exit handler and rethook Masami Hiramatsu (Google)
2023-08-09 10:30 ` Florent Revest
2023-08-09 14:43 ` Masami Hiramatsu
2023-08-09 15:45 ` Florent Revest
2023-08-10 0:32 ` Masami Hiramatsu
2023-08-07 6:49 ` [RFC PATCH v2 4/6] tracing/fprobe: Enable fprobe events with CONFIG_DYNAMIC_FTRACE_WITH_ARGS Masami Hiramatsu (Google)
2023-08-09 10:31 ` Florent Revest
2023-08-09 14:45 ` Masami Hiramatsu
2023-08-09 15:38 ` Florent Revest
2023-08-10 0:38 ` Masami Hiramatsu
2023-08-11 15:57 ` Steven Rostedt
2023-08-07 6:49 ` [RFC PATCH v2 5/6] ftrace: Add ftrace_partial_regs() for converting ftrace_regs to pt_regs Masami Hiramatsu (Google)
2023-08-09 10:31 ` Florent Revest
2023-08-09 14:52 ` Masami Hiramatsu
2023-08-07 6:49 ` [RFC PATCH v2 6/6] bpf: Enable kprobe_multi feature if CONFIG_FPROBE is enabled Masami Hiramatsu (Google)
2023-08-07 22:08 ` Jiri Olsa
2023-08-08 10:20 ` Masami Hiramatsu
2023-08-08 14:29 ` [RFC PATCH v2 0/6] bpf: fprobe: rethook: Use ftrace_regs instead of pt_regs Florent Revest
2023-08-08 14:53 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169139090386.324433.6412259486776991296.stgit@devnote2 \
--to=mhiramat@kernel.org \
--cc=acme@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.lau@linux.dev \
--cc=peterz@infradead.org \
--cc=revest@chromium.org \
--cc=rostedt@goodmis.org \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).