Re: [PATCH v7 23/36] function_graph: Add a new exit handler with parent_ip and ftrace_regs

Masami Hiramatsu
2024-02-16T08:43:34Z

On Thu, 15 Feb 2024 10:49:03 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Wed, 7 Feb 2024 00:11:44 +0900
> "Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
>
> > diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> > index 61c541c36596..308b3bec01b1 100644
> > --- a/kernel/trace/Kconfig
> > +++ b/kernel/trace/Kconfig
> > @@ -34,6 +34,9 @@ config HAVE_FUNCTION_GRAPH_TRACER
> > config HAVE_FUNCTION_GRAPH_RETVAL
> > bool
> >
> > +config HAVE_FUNCTION_GRAPH_FREGS
> > + bool
> > +
> > config HAVE_DYNAMIC_FTRACE
> > bool
> > help
>
> We're starting to get overloaded with the CONFIG_HAVE_* options.
>
> We need to start consolidating them. I would like to make RETVAL and FREGS
> into one option. We can add this now, but before we add anything else, we
> need to see what HAVE configs have the same archs, and then just
> consolidate them. If an new arch wants to add one of the consolidated
> features, it will also need to add all the other features that were
> consolidated with it.

Got it. So RETVAL should be implemented by FREGS or REGS.
Thank you,

>
> -- Steve

--
Masami Hiramatsu (Google) <mhiramat@kernel.org>