From: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Florent Revest <revest@chromium.org>
Cc: linux-trace-kernel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Jiri Olsa <jolsa@kernel.org>,
Alan Maguire <alan.maguire@oracle.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-arch@vger.kernel.org
Subject: [PATCH v16 01/18] tracing: Use arch_ftrace_regs() for ftrace_regs_*() macros
Date: Tue, 15 Oct 2024 10:28:43 +0900 [thread overview]
Message-ID: <172895572290.107311.16057631001860177198.stgit@devnote2> (raw)
In-Reply-To: <172895571278.107311.14000164546881236558.stgit@devnote2>
From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Since the arch_ftrace_get_regs(fregs) is only valid when the
FL_SAVE_REGS is set, we need to use `&arch_ftrace_regs()->regs` for
ftrace_regs_*() APIs because those APIs are for ftrace_regs, not
complete pt_regs.
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
---
include/linux/ftrace_regs.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/linux/ftrace_regs.h b/include/linux/ftrace_regs.h
index dea6a0851b74..b78a0a60515b 100644
--- a/include/linux/ftrace_regs.h
+++ b/include/linux/ftrace_regs.h
@@ -17,17 +17,17 @@ struct __arch_ftrace_regs {
struct ftrace_regs;
#define ftrace_regs_get_instruction_pointer(fregs) \
- instruction_pointer(arch_ftrace_get_regs(fregs))
+ instruction_pointer(&arch_ftrace_regs(fregs)->regs)
#define ftrace_regs_get_argument(fregs, n) \
- regs_get_kernel_argument(arch_ftrace_get_regs(fregs), n)
+ regs_get_kernel_argument(&arch_ftrace_regs(fregs)->regs, n)
#define ftrace_regs_get_stack_pointer(fregs) \
- kernel_stack_pointer(arch_ftrace_get_regs(fregs))
+ kernel_stack_pointer(&arch_ftrace_regs(fregs)->regs)
#define ftrace_regs_return_value(fregs) \
- regs_return_value(arch_ftrace_get_regs(fregs))
+ regs_return_value(&arch_ftrace_regs(fregs)->regs)
#define ftrace_regs_set_return_value(fregs, ret) \
- regs_set_return_value(arch_ftrace_get_regs(fregs), ret)
+ regs_set_return_value(&arch_ftrace_regs(fregs)->regs, ret)
#define ftrace_override_function_with_return(fregs) \
- override_function_with_return(arch_ftrace_get_regs(fregs))
+ override_function_with_return(&arch_ftrace_regs(fregs)->regs)
#define ftrace_regs_query_register_offset(name) \
regs_query_register_offset(name)
next prev parent reply other threads:[~2024-10-15 1:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 1:28 [PATCH v16 00/18] tracing: fprobe: function_graph: Multi-function graph and fprobe on fgraph Masami Hiramatsu (Google)
2024-10-15 1:28 ` Masami Hiramatsu (Google) [this message]
2024-10-15 21:27 ` [PATCH v16 01/18] tracing: Use arch_ftrace_regs() for ftrace_regs_*() macros Steven Rostedt
2024-10-15 23:25 ` Masami Hiramatsu
2024-10-15 23:28 ` Steven Rostedt
2024-10-15 1:28 ` [PATCH v16 02/18] tracing: Rename ftrace_regs_return_value to ftrace_regs_get_return_value Masami Hiramatsu (Google)
2024-10-15 1:29 ` [PATCH v16 03/18] function_graph: Pass ftrace_regs to entryfunc Masami Hiramatsu (Google)
2024-10-15 1:29 ` [PATCH v16 04/18] function_graph: Replace fgraph_ret_regs with ftrace_regs Masami Hiramatsu (Google)
2024-10-15 18:39 ` Heiko Carstens
2024-10-15 23:33 ` Masami Hiramatsu
2024-10-15 23:47 ` Masami Hiramatsu
2024-10-16 8:33 ` Heiko Carstens
2024-10-21 4:22 ` Masami Hiramatsu
2024-10-15 1:29 ` [PATCH v16 05/18] function_graph: Pass ftrace_regs to retfunc Masami Hiramatsu (Google)
2024-10-15 1:29 ` [PATCH v16 06/18] fprobe: Use ftrace_regs in fprobe entry handler Masami Hiramatsu (Google)
2024-10-15 1:29 ` [PATCH v16 07/18] fprobe: Use ftrace_regs in fprobe exit handler Masami Hiramatsu (Google)
2024-10-15 1:30 ` [PATCH v16 08/18] tracing: Add ftrace_partial_regs() for converting ftrace_regs to pt_regs Masami Hiramatsu (Google)
2024-10-15 1:30 ` [PATCH v16 09/18] tracing: Add ftrace_fill_perf_regs() for perf event Masami Hiramatsu (Google)
2024-10-15 18:18 ` Heiko Carstens
2024-10-15 23:34 ` Masami Hiramatsu
2024-10-15 1:30 ` [PATCH v16 10/18] tracing/fprobe: Enable fprobe events with CONFIG_DYNAMIC_FTRACE_WITH_ARGS Masami Hiramatsu (Google)
2024-10-15 1:30 ` [PATCH v16 11/18] bpf: Enable kprobe_multi feature if CONFIG_FPROBE is enabled Masami Hiramatsu (Google)
2024-10-15 1:30 ` [PATCH v16 12/18] ftrace: Add CONFIG_HAVE_FTRACE_GRAPH_FUNC Masami Hiramatsu (Google)
2024-10-15 1:31 ` [PATCH v16 13/18] fprobe: Rewrite fprobe on function-graph tracer Masami Hiramatsu (Google)
2024-10-15 1:31 ` [PATCH v16 14/18] tracing/fprobe: Remove nr_maxactive from fprobe Masami Hiramatsu (Google)
2024-10-15 1:31 ` [PATCH v16 15/18] selftests: ftrace: Remove obsolate maxactive syntax check Masami Hiramatsu (Google)
2024-10-15 1:31 ` [PATCH v16 16/18] selftests/ftrace: Add a test case for repeating register/unregister fprobe Masami Hiramatsu (Google)
2024-10-15 1:31 ` [PATCH v16 17/18] Documentation: probes: Update fprobe on function-graph tracer Masami Hiramatsu (Google)
2024-10-15 1:31 ` [PATCH v16 18/18] bpf: Add get_entry_ip() for arm64 Masami Hiramatsu (Google)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172895572290.107311.16057631001860177198.stgit@devnote2 \
--to=mhiramat@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.lau@linux.dev \
--cc=revest@chromium.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).