[PATCH 0/4] xfs: more unused events from linux-next

[PATCH 0/4] xfs: more unused events from linux-next

[Steven Rostedt]

I reran the unused tracepoint code on the latest linux-next and found more
xfs trace events. One was recently added but the rest were there before. Not
sure how I missed them.

But anyway, here's a few more patches to remove unused xfs trace events.

Steven Rostedt (4):
      xfs: remove unused trace event xfs_dqreclaim_dirty
      xfs: remove unused trace event xfs_log_cil_return
      xfs: remove unused trace event xfs_discard_rtrelax
      xfs: remove unused trace event xfs_reflink_cow_enospc

----
 fs/xfs/xfs_trace.h | 4 ----
 1 file changed, 4 deletions(-)

[PATCH 1/4] xfs: remove unused trace event xfs_dqreclaim_dirty

[Steven Rostedt]

From: Steven Rostedt <rostedt@goodmis.org>

The tracepoint trace_xfs_dqreclaim_dirty was removed with other code
removed from xfs_qm_dquot_isolate() but the defined tracepoint was not.

Fixes: d62016b1a2df ("xfs: avoid dquot buffer pin deadlock")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 fs/xfs/xfs_trace.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h
index 10d4fd671dcf..22c10a1b7fd3 100644
--- a/fs/xfs/xfs_trace.h
+++ b/fs/xfs/xfs_trace.h
@@ -1396,7 +1396,6 @@ DEFINE_EVENT(xfs_dquot_class, name, \
 	TP_ARGS(dqp))
 DEFINE_DQUOT_EVENT(xfs_dqadjust);
 DEFINE_DQUOT_EVENT(xfs_dqreclaim_want);
-DEFINE_DQUOT_EVENT(xfs_dqreclaim_dirty);
 DEFINE_DQUOT_EVENT(xfs_dqreclaim_busy);
 DEFINE_DQUOT_EVENT(xfs_dqreclaim_done);
 DEFINE_DQUOT_EVENT(xfs_dqattach_found);
-- 
2.47.2

[PATCH 2/4] xfs: remove unused trace event xfs_log_cil_return

[Steven Rostedt]

From: Steven Rostedt <rostedt@goodmis.org>

The trace event xfs_log_cil_return was added but never used. Remove it.

Fixes: c1220522ef405 ("xfs: grant heads track byte counts, not LSNs")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 fs/xfs/xfs_trace.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h
index 22c10a1b7fd3..4ce8689ed839 100644
--- a/fs/xfs/xfs_trace.h
+++ b/fs/xfs/xfs_trace.h
@@ -1600,7 +1600,6 @@ DEFINE_LOGGRANT_EVENT(xfs_log_ticket_ungrant);
 DEFINE_LOGGRANT_EVENT(xfs_log_ticket_ungrant_sub);
 DEFINE_LOGGRANT_EVENT(xfs_log_ticket_ungrant_exit);
 DEFINE_LOGGRANT_EVENT(xfs_log_cil_wait);
-DEFINE_LOGGRANT_EVENT(xfs_log_cil_return);
 
 DECLARE_EVENT_CLASS(xfs_log_item_class,
 	TP_PROTO(struct xfs_log_item *lip),
-- 
2.47.2

[PATCH 3/4] xfs: remove unused trace event xfs_discard_rtrelax

[Steven Rostedt]

From: Steven Rostedt <rostedt@goodmis.org>

The trace event xfs_discard_rtrelax was added but never used. Remove it.

Fixes: a330cae8a7147 ("xfs: Remove header files which are included more than once")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 fs/xfs/xfs_trace.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h
index 4ce8689ed839..1061992da144 100644
--- a/fs/xfs/xfs_trace.h
+++ b/fs/xfs/xfs_trace.h
@@ -2858,7 +2858,6 @@ DEFINE_EVENT(xfs_rtdiscard_class, name, \
 	TP_ARGS(mp, rtbno, len))
 DEFINE_RTDISCARD_EVENT(xfs_discard_rtextent);
 DEFINE_RTDISCARD_EVENT(xfs_discard_rttoosmall);
-DEFINE_RTDISCARD_EVENT(xfs_discard_rtrelax);
 
 DECLARE_EVENT_CLASS(xfs_btree_cur_class,
 	TP_PROTO(struct xfs_btree_cur *cur, int level, struct xfs_buf *bp),
-- 
2.47.2

[PATCH 4/4] xfs: remove unused trace event xfs_reflink_cow_enospc

[Steven Rostedt]

From: Steven Rostedt <rostedt@goodmis.org>

The call to the event xfs_reflink_cow_enospc was removed when the COW
handling was merged into xfs_file_iomap_begin_delay, but the trace event
itself was not. Remove it.

Fixes: db46e604adf8 ("xfs: merge COW handling into xfs_file_iomap_begin_delay")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 fs/xfs/xfs_trace.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h
index 1061992da144..e1794e3e3156 100644
--- a/fs/xfs/xfs_trace.h
+++ b/fs/xfs/xfs_trace.h
@@ -4181,7 +4181,6 @@ DEFINE_INODE_ERROR_EVENT(xfs_reflink_unshare_error);
 /* copy on write */
 DEFINE_INODE_IREC_EVENT(xfs_reflink_trim_around_shared);
 DEFINE_INODE_IREC_EVENT(xfs_reflink_cow_found);
-DEFINE_INODE_IREC_EVENT(xfs_reflink_cow_enospc);
 DEFINE_INODE_IREC_EVENT(xfs_reflink_convert_cow);
 
 DEFINE_SIMPLE_IO_EVENT(xfs_reflink_cancel_cow_range);
-- 
2.47.2

Re: [PATCH 0/4] xfs: more unused events from linux-next

[Darrick J. Wong]

On Tue, Jul 22, 2025 at 04:19:07PM -0400, Steven Rostedt wrote:
> 
> I reran the unused tracepoint code on the latest linux-next and found more
> xfs trace events. One was recently added but the rest were there before. Not
> sure how I missed them.
> 
> But anyway, here's a few more patches to remove unused xfs trace events.
> 
> Steven Rostedt (4):
>       xfs: remove unused trace event xfs_dqreclaim_dirty
>       xfs: remove unused trace event xfs_log_cil_return
>       xfs: remove unused trace event xfs_discard_rtrelax
>       xfs: remove unused trace event xfs_reflink_cow_enospc

I can directly take responsibility for 1, 3, and 4 -- those aren't going
to come back.  Patch 2 looks like an accidental add, and if anyone wants
it they can always add it back.

Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> 
> ----
>  fs/xfs/xfs_trace.h | 4 ----
>  1 file changed, 4 deletions(-)
> 

Re: [PATCH 0/4] xfs: more unused events from linux-next

[Steven Rostedt]

On Tue, 22 Jul 2025 16:28:42 -0700
"Darrick J. Wong" <djwong@kernel.org> wrote:

> On Tue, Jul 22, 2025 at 04:19:07PM -0400, Steven Rostedt wrote:
> > 
> > I reran the unused tracepoint code on the latest linux-next and found more
> > xfs trace events. One was recently added but the rest were there before. Not
> > sure how I missed them.
> > 
> > But anyway, here's a few more patches to remove unused xfs trace events.
> > 
> > Steven Rostedt (4):
> >       xfs: remove unused trace event xfs_dqreclaim_dirty
> >       xfs: remove unused trace event xfs_log_cil_return
> >       xfs: remove unused trace event xfs_discard_rtrelax
> >       xfs: remove unused trace event xfs_reflink_cow_enospc  
> 
> I can directly take responsibility for 1, 3, and 4 -- those aren't going
> to come back.  Patch 2 looks like an accidental add, and if anyone wants
> it they can always add it back.
> 
> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

Thanks. I'm guessing this will also go through the xfs tree?

-- Steve

Re: [PATCH 0/4] xfs: more unused events from linux-next

[Christoph Hellwig]

The entire series looks good to me:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Re: [PATCH 0/4] xfs: more unused events from linux-next

[Carlos Maiolino]

On Tue, 22 Jul 2025 16:19:07 -0400, Steven Rostedt wrote:
> I reran the unused tracepoint code on the latest linux-next and found more
> xfs trace events. One was recently added but the rest were there before. Not
> sure how I missed them.
> 
> But anyway, here's a few more patches to remove unused xfs trace events.
> 
> Steven Rostedt (4):
>       xfs: remove unused trace event xfs_dqreclaim_dirty
>       xfs: remove unused trace event xfs_log_cil_return
>       xfs: remove unused trace event xfs_discard_rtrelax
>       xfs: remove unused trace event xfs_reflink_cow_enospc
> 
> [...]

Applied to for-next, thanks!

[1/4] xfs: remove unused trace event xfs_dqreclaim_dirty
      commit: 1edc170bb24082785e5825c46a36af8ae12ac762
[2/4] xfs: remove unused trace event xfs_log_cil_return
      commit: 55edb3326b4b07117d0c26cd67d86fb8518ee906
[3/4] xfs: remove unused trace event xfs_discard_rtrelax
      commit: c17f506f0abe67b6009c0d126da81a71fc1e00c1
[4/4] xfs: remove unused trace event xfs_reflink_cow_enospc
      commit: 10a957e43f28105ceb7b8e31a918d1c47cd4df3e

Best regards,
-- 
Carlos Maiolino <cem@kernel.org>