* [for-next PATCH v2] tracing: wprobe: Fix to use IS_ERR_PCPU() for per-cpu pointer
@ 2025-10-07 1:03 Masami Hiramatsu (Google)
2025-10-07 3:12 ` Menglong Dong
0 siblings, 1 reply; 3+ messages in thread
From: Masami Hiramatsu (Google) @ 2025-10-07 1:03 UTC (permalink / raw)
To: Steven Rostedt
Cc: Mark Brown, Linus Torvalds, Menglong Dong, Thorsten Blum,
Masami Hiramatsu, linux-kernel, linux-trace-kernel
From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Since wprobe uses IS_ERR() for per-cpu pointer, it failed to build.
/tmp/next/build/kernel/trace/trace_wprobe.c: In function '__register_trace_wprobe':
/tmp/next/build/kernel/trace/trace_wprobe.c:176:20: error: cast to generic address space pointer from disjoint '__seg_gs' address space pointer [-Werror]
176 | if (IS_ERR((void * __force)tw->bp_event)) {
| ^
/tmp/next/build/kernel/trace/trace_wprobe.c:177:35: error: cast to generic address space pointer from disjoint '__seg_gs' address space pointer [-Werror]
177 | int ret = PTR_ERR((void * __force)tw->bp_event);
| ^
Use IS_ERR_PCPU() instead.
Reported-by: Mark Brown <broonie@kernel.org>
Closes: https://lore.kernel.org/all/aN6fTmAjD7-SJsw2@sirena.org.uk/
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
---
- Confirmed that `make allmodconfig && make` passed on x86_64 and arm64.
Changes in v2:
- Remove unneeded casting.
- Use PTR_ERR_PCPU() too.
---
kernel/trace/trace_wprobe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/trace_wprobe.c b/kernel/trace/trace_wprobe.c
index 4b00a8e917c1..98605b207f43 100644
--- a/kernel/trace/trace_wprobe.c
+++ b/kernel/trace/trace_wprobe.c
@@ -173,8 +173,8 @@ static int __register_trace_wprobe(struct trace_wprobe *tw)
attr.bp_type = tw->type;
tw->bp_event = register_wide_hw_breakpoint(&attr, wprobe_perf_handler, tw);
- if (IS_ERR((void * __force)tw->bp_event)) {
- int ret = PTR_ERR((void * __force)tw->bp_event);
+ if (IS_ERR_PCPU(tw->bp_event)) {
+ int ret = PTR_ERR_PCPU(tw->bp_event);
tw->bp_event = NULL;
return ret;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [for-next PATCH v2] tracing: wprobe: Fix to use IS_ERR_PCPU() for per-cpu pointer
2025-10-07 1:03 [for-next PATCH v2] tracing: wprobe: Fix to use IS_ERR_PCPU() for per-cpu pointer Masami Hiramatsu (Google)
@ 2025-10-07 3:12 ` Menglong Dong
2025-10-07 13:57 ` Masami Hiramatsu
0 siblings, 1 reply; 3+ messages in thread
From: Menglong Dong @ 2025-10-07 3:12 UTC (permalink / raw)
To: Steven Rostedt, Masami Hiramatsu (Google)
Cc: Mark Brown, Linus Torvalds, Menglong Dong, Thorsten Blum,
Masami Hiramatsu, linux-kernel, linux-trace-kernel
On 2025/10/7 09:03, Masami Hiramatsu (Google) wrote:
> From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> Since wprobe uses IS_ERR() for per-cpu pointer, it failed to build.
>
> /tmp/next/build/kernel/trace/trace_wprobe.c: In function '__register_trace_wprobe':
> /tmp/next/build/kernel/trace/trace_wprobe.c:176:20: error: cast to generic address space pointer from disjoint '__seg_gs' address space pointer [-Werror]
> 176 | if (IS_ERR((void * __force)tw->bp_event)) {
> | ^
> /tmp/next/build/kernel/trace/trace_wprobe.c:177:35: error: cast to generic address space pointer from disjoint '__seg_gs' address space pointer [-Werror]
> 177 | int ret = PTR_ERR((void * __force)tw->bp_event);
> | ^
>
> Use IS_ERR_PCPU() instead.
>
> Reported-by: Mark Brown <broonie@kernel.org>
> Closes: https://lore.kernel.org/all/aN6fTmAjD7-SJsw2@sirena.org.uk/
> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> ---
> - Confirmed that `make allmodconfig && make` passed on x86_64 and arm64.
> Changes in v2:
> - Remove unneeded casting.
> - Use PTR_ERR_PCPU() too.
> ---
> kernel/trace/trace_wprobe.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/trace/trace_wprobe.c b/kernel/trace/trace_wprobe.c
> index 4b00a8e917c1..98605b207f43 100644
> --- a/kernel/trace/trace_wprobe.c
> +++ b/kernel/trace/trace_wprobe.c
> @@ -173,8 +173,8 @@ static int __register_trace_wprobe(struct trace_wprobe *tw)
> attr.bp_type = tw->type;
>
> tw->bp_event = register_wide_hw_breakpoint(&attr, wprobe_perf_handler, tw);
> - if (IS_ERR((void * __force)tw->bp_event)) {
> - int ret = PTR_ERR((void * __force)tw->bp_event);
> + if (IS_ERR_PCPU(tw->bp_event)) {
> + int ret = PTR_ERR_PCPU(tw->bp_event);
This version LGTM.
Reviewed-by: Menglong Dong <menglong8.dong@gmail.com>
>
> tw->bp_event = NULL;
> return ret;
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [for-next PATCH v2] tracing: wprobe: Fix to use IS_ERR_PCPU() for per-cpu pointer
2025-10-07 3:12 ` Menglong Dong
@ 2025-10-07 13:57 ` Masami Hiramatsu
0 siblings, 0 replies; 3+ messages in thread
From: Masami Hiramatsu @ 2025-10-07 13:57 UTC (permalink / raw)
To: Menglong Dong
Cc: Steven Rostedt, Mark Brown, Linus Torvalds, Menglong Dong,
Thorsten Blum, linux-kernel, linux-trace-kernel
On Tue, 07 Oct 2025 11:12:18 +0800
Menglong Dong <menglong.dong@linux.dev> wrote:
> On 2025/10/7 09:03, Masami Hiramatsu (Google) wrote:
> > From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> >
> > Since wprobe uses IS_ERR() for per-cpu pointer, it failed to build.
> >
> > /tmp/next/build/kernel/trace/trace_wprobe.c: In function '__register_trace_wprobe':
> > /tmp/next/build/kernel/trace/trace_wprobe.c:176:20: error: cast to generic address space pointer from disjoint '__seg_gs' address space pointer [-Werror]
> > 176 | if (IS_ERR((void * __force)tw->bp_event)) {
> > | ^
> > /tmp/next/build/kernel/trace/trace_wprobe.c:177:35: error: cast to generic address space pointer from disjoint '__seg_gs' address space pointer [-Werror]
> > 177 | int ret = PTR_ERR((void * __force)tw->bp_event);
> > | ^
> >
> > Use IS_ERR_PCPU() instead.
> >
> > Reported-by: Mark Brown <broonie@kernel.org>
> > Closes: https://lore.kernel.org/all/aN6fTmAjD7-SJsw2@sirena.org.uk/
> > Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
> > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> > ---
> > - Confirmed that `make allmodconfig && make` passed on x86_64 and arm64.
> > Changes in v2:
> > - Remove unneeded casting.
> > - Use PTR_ERR_PCPU() too.
> > ---
> > kernel/trace/trace_wprobe.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/kernel/trace/trace_wprobe.c b/kernel/trace/trace_wprobe.c
> > index 4b00a8e917c1..98605b207f43 100644
> > --- a/kernel/trace/trace_wprobe.c
> > +++ b/kernel/trace/trace_wprobe.c
> > @@ -173,8 +173,8 @@ static int __register_trace_wprobe(struct trace_wprobe *tw)
> > attr.bp_type = tw->type;
> >
> > tw->bp_event = register_wide_hw_breakpoint(&attr, wprobe_perf_handler, tw);
> > - if (IS_ERR((void * __force)tw->bp_event)) {
> > - int ret = PTR_ERR((void * __force)tw->bp_event);
> > + if (IS_ERR_PCPU(tw->bp_event)) {
> > + int ret = PTR_ERR_PCPU(tw->bp_event);
>
> This version LGTM.
>
> Reviewed-by: Menglong Dong <menglong8.dong@gmail.com>
Thank you! Let me push it in probes/for-next.
>
> >
> > tw->bp_event = NULL;
> > return ret;
> >
> >
> >
>
>
>
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-07 13:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-07 1:03 [for-next PATCH v2] tracing: wprobe: Fix to use IS_ERR_PCPU() for per-cpu pointer Masami Hiramatsu (Google)
2025-10-07 3:12 ` Menglong Dong
2025-10-07 13:57 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).