From: Miroslav Benes <mbenes@suse.cz>
To: Andrey Grodzovsky <andrey.grodzovsky@crowdstrike.com>
Cc: Song Liu <song@kernel.org>, Steven Rostedt <rostedt@goodmis.org>,
bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
live-patching@vger.kernel.org, mbenes@suse.cz, jolsa@kernel.org,
mhiramat@kernel.org, jpoimboe@kernel.org,
joe.lawrence@redhat.com, mark.rutland@arm.com, corbet@lwn.net,
stable@vger.kernel.org, linux-open-source@crowdstrike.com
Subject: Re: [RFC PATCH bpf-next v3 1/2] ftrace: deprecate disabling via ftrace_enabled sysctl
Date: Mon, 24 Aug 2026 14:27:21 +0200 [thread overview]
Message-ID: <178757444126.29054.5684338666506602450.b4-reply@b4> (raw)
In-Reply-To: <CAOu3gNhgRTh8uZdfNf+XBpYuJWAFu5i+UNjQC2jce4DdRc-bGg@mail.gmail.com>
On 2026-08-09 14:32:16-04:00, Andrey Grodzovsky wrote:
> On Thu, Aug 6, 2026 at 5:52 PM Andrey Grodzovsky
> <andrey.grodzovsky@crowdstrike.com> wrote:
>
> > On Thu, Aug 6, 2026 at 5:22 PM Song Liu <song@kernel.org> wrote:
> >
> > The bot has 2 comments.
> >
> > In my opinion, the test-breaking comment is wrong as he looked
> > strictly at this patch w/o reviewing the follow-up live patch testing
> > changes which update the tests to avoid breaks.
> >
> > The cleanup comment is valid but since we aren't sure if we'll need to
> > revert this change later if it breaks userspace in some unseen way, I
> > wonder how extensive the cleanup should be? Steven, can you advise
> > please ?
> >
> > Andrey
>
> Gentle ping on this question above Steven.
I am not Steven but I think we should wait with the cleanup exactly
due to a possible revert. The same as for PERMANENT flag we talked about
elsewhere.
next prev parent reply other threads:[~2026-08-24 12:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 15:29 [RFC PATCH bpf-next v3 0/2] ftrace: deprecate the ftrace_enabled disable switch Andrey Grodzovsky
2026-08-06 15:29 ` [RFC PATCH bpf-next v3 1/2] ftrace: deprecate disabling via ftrace_enabled sysctl Andrey Grodzovsky
2026-08-06 21:21 ` Song Liu
2026-08-06 21:52 ` Andrey Grodzovsky
2026-08-09 18:32 ` Andrey Grodzovsky
2026-08-24 12:27 ` Miroslav Benes [this message]
2026-08-24 12:30 ` Miroslav Benes
2026-08-06 15:30 ` [RFC PATCH bpf-next v3 2/2] selftests/livepatch: update test-ftrace.sh for deprecated ftrace_enabled Andrey Grodzovsky
2026-08-06 21:18 ` Song Liu
2026-08-06 21:45 ` Andrey Grodzovsky
2026-08-07 0:51 ` Steven Rostedt
2026-08-07 7:17 ` Song Liu
2026-08-07 12:42 ` Steven Rostedt
2026-08-07 16:16 ` Song Liu
2026-08-24 12:41 ` Miroslav Benes
2026-08-24 12:41 ` Miroslav Benes
2026-08-25 13:12 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178757444126.29054.5684338666506602450.b4-reply@b4 \
--to=mbenes@suse.cz \
--cc=andrey.grodzovsky@crowdstrike.com \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=joe.lawrence@redhat.com \
--cc=jolsa@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=linux-open-source@crowdstrike.com \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=song@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox