From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-00364e01.pphosted.com (mx0b-00364e01.pphosted.com [148.163.139.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5F55DF6C for ; Sat, 29 Aug 2026 18:43:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.139.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788028982; cv=none; b=GdJCfYLxT5Bxd5o2e9Qw8GCNad+Q0y35ajHg0PqsCI2BDG2KtnzadVeHxJhxQv02+pw+PcPLDZpRItghr+8c+3ex7LMbLklg62JR0uqGWquvb883gk0E1L17vUvThQjH4rpxENGJfmZRSgDlp7cwhrgIQrwMXd7o8crvnx/x51g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788028982; c=relaxed/simple; bh=8Gj2G76gEDUSTrJh9wyKhjlV0WDG+1riVaR0UmTV1c4=; h=MIME-Version:Content-Type:Subject:From:To:Cc:In-Reply-To: References:Date:Message-Id; b=pLkHNXCM+OF5/Vxk8c6ojAHSwAS+eIJmhRvhzv5L0EyN7ktOkSMdxqsYMtFYxEupD5evRWQ56bPcaizujTB+W3EkwPj5pohu1XQ8qD9yGtOFbaYqIGo9G17r75rmyAivgCNVqGdoWUegsnpqsYUQawAFF4FbA1keFHaSJEkOcWo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu; spf=pass smtp.mailfrom=columbia.edu; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b=YaJycs+P; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b=xJMFBU7G; arc=none smtp.client-ip=148.163.139.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=columbia.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b="YaJycs+P"; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b="xJMFBU7G" Received: from pps.filterd (m0167077.ppops.net [127.0.0.1]) by mx0b-00364e01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67TIYsOE1452365 for ; Sat, 29 Aug 2026 14:42:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps01; bh=0bd5 PAmYpGy8JaYT1BKzRh2l/HCvYP+lW1f+KIURCm8=; b=YaJycs+PgkXAxiEmTQzc x40/bpBx1OYZh241szBo3lKKjWsHNNTm/SUNCPAfRi3n/VvGgS3pPmiT6vJfeTeE GiYqlQAcB9LxnBFHNoESzb5esOccev9qrcQWHm0gEHQGot5RZ3TlnUHgTh1mlvDz d9N5rHFvicpTxBVJ1Kc7qEh1Y27NhJ6xXj8g377SAqIe5++so+krlfoZAvQs/gIU kCMT6z/E5NYAilPWjvHEyj6ymy4uPe3Gtsnyao6hjzXSseIMYastb0rZJFYPC+xh 8rKV341s6RpP56zWTz8d8V831a4RBpe5IcA1BvubzOBoLFQUXRg3oy5g0dCR/q6W 2A== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0b-00364e01.pphosted.com (PPS) with ESMTPS id 4gbs0ptuhm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 29 Aug 2026 14:42:59 -0400 (EDT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-52ff59f2c47so24280721cf.1 for ; Sat, 29 Aug 2026 11:42:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; s=lionmail; t=1788028979; x=1788633779; darn=vger.kernel.org; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:content-type:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=0bd5PAmYpGy8JaYT1BKzRh2l/HCvYP+lW1f+KIURCm8=; b=xJMFBU7GQCayIbfE/cZMP8mwh0IfylQylrPhUpZBxmpVYi2RVGAjfDyeBsDEwx9xzd TfrpRpffrA/wJ6xl9pQYcSVBhmEKp9cDktrlyJojPzwSDh4OA40bIIK/lPQYNv4qiejL Ui4/zvXdVV1fseG53Y3bbx05exgxDw/IqliY8WXjDbo65O8jB2hu4kgVxZV9V+4phyKk 1KyvFBv7Q8Oj9PIPcEy99NQJ6X0Y9HpYMDP1lDnhiAQc4uLTX1Y6+HABwvmdTv/BthEj quQK3NYVN5hBoiMWWqQpwMP+iIedprzIMuUaz/g9KiNUtGdZnLUjB709S9MnDJCQyu9H q9ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788028979; x=1788633779; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:content-type:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0bd5PAmYpGy8JaYT1BKzRh2l/HCvYP+lW1f+KIURCm8=; b=DWomufp5l0BUIQmesykqssbjh9W9rN5wiTM69UTKzlKdrsYN19sBAFtdUd2psVaYD+ 4+iwAA3zbWjoTpV7AeDKYTOz+I69Dx+JTMUh/7e5+sPxUxDmd0yBtK+wMkuczd43crs5 HXA3ehJzqv3xsiUtn+HjLh4p1yZWY1XGRZZOsFe3PLBtlAb4lfpUpK2JxAfZJL9IRYK9 qUvUA7onRd8te0n8gKpgjGj6I29XE2UE3X2vviyXEOEl9KB4QJhAWrk2Vdok5QoD40fh /ocKvMzZS8yNv8RiamIv0s/KGtnCG80oX5gY40Y/bVWI0nhXhCMQ0rCDEb84ikYgeCpl qEQA== X-Forwarded-Encrypted: i=1; AHgh+RqYg6vpv99fyEGFLN1dUwrklSB4siMzAIvgGX2B0MoHJZg6Fcr0/zVmye2KLz+nVjk1bv2tRPY/n6MsqpLYFdSsLvQ=@vger.kernel.org X-Gm-Message-State: AFuF++ntbBErU809Rwco8IOHQeqeV8t7ursNrr2LcqMGzDByE4k9e3JM 4o3AjPlagbCZrypzEhYu/gpO0u5eZUYOi+SR4x/VmYs7fd94Gz1gmwL4VohDMFI+sjCgzlwcXQ+ epeJS1IB8LE71S1A1n4jJn6SP1peBZKjA7c3XCh10kkt9Fg7SeCxz75FZU14uBOB2krmNBw== X-Gm-Gg: AR+sD11xs8Mkf1PXRXitI/DhMuTLm23/RlvG8PE+3O7lNd01PNXrj5+KrNQJntKjm/f OF2kHDatIWeAlucC09iK9mlD1EOz3O3QAfXGN0SUQ8hAGZWdf2fm7MBr5nqLA9r/kA0k82Vz9Fa EoDAXuvgOlwBbx2QaTDnCLHM0mfizcimKMyLUIfYm8yHn3MNObD636fno66i2eY5tFERZUdN6Mh xWuCzY2PHr1A3KsB/LXX/cN6Jfbhmz80woamUlJPYVeMvyPgGvYUGaguZsITpsaNUfuRHS7CKsa tTd47cmsBdgxV7mtc6xsWoecSEMI55N6PmStrntMjn+YR6jIlpaUry1NTe4bAKoX8FJKiCy6OH/ 8r2bYgxF6fPJoGha/uQAudm701k87tv5jhu5HRDqIy/oVwII= X-Received: by 2002:a05:622a:1910:b0:52e:4982:22cc with SMTP id d75a77b69052e-52fa1a4aab2mr249923161cf.5.1788028979074; Sat, 29 Aug 2026 11:42:59 -0700 (PDT) X-Received: by 2002:a05:622a:1910:b0:52e:4982:22cc with SMTP id d75a77b69052e-52fa1a4aab2mr249922571cf.5.1788028978606; Sat, 29 Aug 2026 11:42:58 -0700 (PDT) Received: from [127.0.1.1] (bzq-79-179-7-133.red.bezeqint.net. [79.179.7.133]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482fbb32d30sm12171637f8f.34.2026.08.29.11.42.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Aug 2026 11:42:57 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 6/6] userfaultfd: collapse VM_UFFD_{MISSING,WP,MINOR,RWP} into single VM_UFFD From: Tal Zussman To: Mike Rapoport Cc: "David Hildenbrand (Arm)" , "Lorenzo Stoakes (ARM)" , Andrew Morton , Baolin Wang , Barry Song , Dev Jain , Hugh Dickins , Jann Horn , Jason Gunthorpe , John Hubbard , Jonathan Corbet , Lance Yang , "Liam R. Howlett" , Masami Hiramatsu , Mathieu Desnoyers , Michal Hocko , Muchun Song , Nico Pache , Oscar Salvador , Pedro Falcato , Peter Xu , Ryan Roberts , Shakeel Butt , Shuah Khan , Steven Rostedt , Suren Baghdasaryan , Usama Arif , Vlastimil Babka , Zi Yan , linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org In-Reply-To: References: <20260823-uffd-vm-flags-v1-v1-0-3086981b33cf@kernel.org> <20260823-uffd-vm-flags-v1-v1-6-3086981b33cf@kernel.org> <37f6af95-950e-4457-886e-6548d4719f0d@kernel.org> Date: Sat, 29 Aug 2026 14:42:52 -0400 Message-Id: <178802897277.671075.10362065249796431311.b4-reply@b4> X-Mailer: b4 0.17-dev-db0b7 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788028972; l=1768; i=tz2294@columbia.edu; s=20250528; h=from:subject:message-id; bh=8Gj2G76gEDUSTrJh9wyKhjlV0WDG+1riVaR0UmTV1c4=; b=cMv3WyS297uSy6OhyEPKL7TFiV6NgPyRlli6/52vFPU3U+wxk43IDrwyt65mNyPQi/updU28Q fXkQOPOdareAvP+hQQ2rgHqvMZY30DpDTGX/m0/lnTSj2MdkKXGNeAi X-Developer-Key: i=tz2294@columbia.edu; a=ed25519; pk=BIj5KdACscEOyAC0oIkeZqLB3L94fzBnDccEooxeM5Y= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI5MDE2MCBTYWx0ZWRfXzj+YFPcRWxgI LB6h4vxKyFGiXzgihyxqtPMSmjvsitKemvIj5qZSfuB13YKnBKlETeD4G2t8m0vQtmbIhE4Hgkn xxX8j0rajORiHC5QkVI0A8s8PJO97F1th79I33fUjHEq4p6zC4NTFqBGsFkA1nDcYEkBvGnleS0 VEn0gcdruFPwZUrueIXEGbxl+htzBInb8qrdHpU/0dHuEbaE1hNn4iQ7po01aEwX7mqqUWi9ajT UiZGb7+Cgpy5mniIp/NTfd7FCXwUasYj8L151Sfz5DrM7t+mP0utnrY4FefYLUrsjBie3IwVXH6 iiXT7Mvyk6EH3C7XRQUZopefjd4RTpDGp8G6gihFd0WPeFzox19ETEEw1L2hb7VWuFuxmOn7DUS GqOdjvIJ5AaGnfR0ywVxv3Lc2NcmIMQXiPsIpsh9nE4z80MwL58UYDyAPehfboLoT0iIrn7nrYA UqcQhlrWKhUu9bA6AeQ== X-Authority-Analysis: v=2.4 cv=EtbiaycA c=1 sm=1 tr=0 ts=6a932833 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=LRATYcvZeiQrLRB5MfbBvg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=x7bEGLp0ZPQA:10 a=A0y_DWxS2BwA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Da8U98TiO7q1upZEImrf:22 a=QOCMdifcju39GKoXhKua:22 a=kX8B4L1VaituP6mSkuYA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODI5MDE2MCBTYWx0ZWRfX/hU4JuBJTZYD CP6K07CJ5rndGNItPUDFUIENLX78mDMXz0zW9rzCP44X6DJlmQcIzkosYGGily3CbhQEyMZtXGH r9i2kTsI093NpHHV79bilwCjzsCM492nw2Jb0YEG6UqBlSvLA5aM X-Proofpoint-ORIG-GUID: R0-0Gv41vyH48YcN9WMEId_3LH2nTDGp X-Proofpoint-GUID: R0-0Gv41vyH48YcN9WMEId_3LH2nTDGp X-Proofpoint-Virus-Version: vendor=nai engine=6900 definitions=11890 signatures=596817 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 adultscore=0 lowpriorityscore=10 spamscore=0 clxscore=1011 impostorscore=10 phishscore=0 bulkscore=10 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608290160 On 2026-08-29 14:00 +0300, Mike Rapoport wrote: > On Thu, Aug 27, 2026 at 05:19:30PM +0200, David Hildenbrand (Arm) wrote: > > On 8/27/26 13:18, Lorenzo Stoakes (ARM) wrote: > > > On Thu, Aug 27, 2026 at 12:16:32PM +0100, Lorenzo Stoakes (ARM) wrote: > > >> So actually you're increasing by a cacheline and increasing the VMA size by > > >> 64 bytes, i.e. 1/3, which is unacceptable obviously. > > >> > > >> Maybe there's something that can be done with: > > >> > > >> /* forced alignments: 1 */ > > >> > > >> Perhaps? But that looks potentially ugly. > > >> > > > > > > I say elsewhere (or think I do) but to highlight - I think probably we could fix > > > this by putting the flags in the low bits of vm_uffd_state.ctx? > > > > if that's possible that would be clearly preferable memory-wise. > > This gives only 4 bits and makes this completely not extendable. Wouldn't it be 6 bits? struct userfaultfd_ctx is allocated with kmem_cache_create() and SLAB_HWCACHE_ALIGN, and most of the flags are only available on 64 bit, so it should be 64-byte aligned in the relevant cases. (Not that 6 is that much better than 4... but it's a little more wiggle room.) It could in theory also be bumped up to 7 by setting align in kmem_cache_create(). userfaultfd_ctx already takes 192 bytes due to existing alignment. Aligning it to 128 bytes would make it 256 bytes, adding 64 bytes to each uffd rather than each VMA. But this sounds like more pain for little gain :) > So I think I'll drop this for now and wait until VMA grows another cache > line or until having per-VMA uffd state rather than a pointer to per-fd > context is a must. > > > -- > > Cheers, > > > > David > > -- > Sincerely yours, > Mike. > >