Re: [PATCH v4 10/15] sched: Add task enqueue/dequeue trace points

[K Prateek Nayak <kprateek.nayak@amd.com>]

Hello Gabriele, Nam,

On 1/16/2026 6:09 PM, Gabriele Monaco wrote:
> @@ -2087,6 +2087,8 @@ unsigned long get_wchan(struct task_struct *p)
>  
>  void enqueue_task(struct rq *rq, struct task_struct *p, int flags)
>  {

For delayed task, I think you'll need:

	if (trace_sched_enqueue_tp_enabled() && !(flags & ENQUEUE_DELAYED))

> +		trace_sched_enqueue_tp(p, rq->cpu);
> +
>  	if (!(flags & ENQUEUE_NOCLOCK))
>  		update_rq_clock(rq);

Since delayed tasks haven't hit __block_task(), they are essentially
still enqueued. Peter should be able to confirm. Other than that,
the placements of the tracepoints look good now. Feel free to include:

Reviewed-by: K Prateek Nayak <kprateek.nayak@amd.com>

-- 
Thanks and Regards,
Prateek