public inbox for linux-trace-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "jempty.liang" <imntjempty@163.com>
To: "Steven Rostedt" <rostedt@goodmis.org>
Cc: mhiramat@kernel.org, mark.rutland@arm.com,
	mathieu.desnoyers@efficios.com, linux-kernel@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tracing: Fix funcgraph_exit calltime/rettime offset for 32-bit ARM
Date: Tue, 3 Feb 2026 18:04:21 +0800 (CST)	[thread overview]
Message-ID: <19eab264.7fae.19c22f5d17c.Coremail.imntjempty@163.com> (raw)
In-Reply-To: <20260202110828.440c8d44@gandalf.local.home>

At 2026-02-03 00:08:28, "Steven Rostedt" <rostedt@goodmis.org> wrote:
>On Mon, 2 Feb 2026 10:38:04 -0500
>Steven Rostedt <rostedt@goodmis.org> wrote:
>
>> Can you try this patch to see if it fixes the issue for you?
>
>Ignore that patch, try this one instead. This was fixed for trace_events a
>while ago, but the same fix wasn't done for ftrace events.
>
>-- Steve
>
>diff --git a/kernel/trace/trace_export.c b/kernel/trace/trace_export.c
>index 1698fc22afa0..5b96ac750049 100644
>--- a/kernel/trace/trace_export.c
>+++ b/kernel/trace/trace_export.c
>@@ -14,6 +14,9 @@
> 
> #include "trace_output.h"
> 
>+/* The alignment of a type when in a structure */
>+#define ALIGN_STRUCTFIELD(type) ((int)(__alignof__(struct {type b;})))
>+
> /* Stub function for events with triggers */
> static int ftrace_event_register(struct trace_event_call *call,
> 				 enum trace_reg type, void *data)
>@@ -88,7 +91,7 @@ static void __always_unused ____ftrace_check_##name(void)		\
> #undef __field_ext
> #define __field_ext(_type, _item, _filter_type) {			\
> 	.type = #_type, .name = #_item,					\
>-	.size = sizeof(_type), .align = __alignof__(_type),		\
>+	.size = sizeof(_type), .align = ALIGN_STRUCTFIELD(_type),	\
> 	is_signed_type(_type), .filter_type = _filter_type },
> 
On the 32-bit ARM platform, when _type is unsigned long long, the resulting align value is 8 instead of the expected 4.
> 

  reply	other threads:[~2026-02-03 10:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02 12:33 [PATCH v2] tracing: Fix funcgraph_exit calltime/rettime offset for 32-bit ARM jempty.liang
2026-02-02 15:38 ` Steven Rostedt
2026-02-02 16:08   ` Steven Rostedt
2026-02-03 10:04     ` jempty.liang [this message]
2026-02-03 14:30       ` Steven Rostedt
2026-02-03 16:20         ` Steven Rostedt
2026-02-04  1:21           ` jempty.liang
2026-02-03  9:42   ` jempty.liang
2026-02-03  4:06 ` kernel test robot
2026-02-03  4:26 ` kernel test robot
2026-02-03  5:50 ` kernel test robot
2026-02-03  7:18 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19eab264.7fae.19c22f5d17c.Coremail.imntjempty@163.com \
    --to=imntjempty@163.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox