From: Ajay Kaher <akaher@vmware.com>
To: kernel test robot <lkp@intel.com>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"mhiramat@kernel.org" <mhiramat@kernel.org>,
"shuah@kernel.org" <shuah@kernel.org>
Cc: "llvm@lists.linux.dev" <llvm@lists.linux.dev>,
"oe-kbuild-all@lists.linux.dev" <oe-kbuild-all@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-trace-kernel@vger.kernel.org"
<linux-trace-kernel@vger.kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"chinglinyu@google.com" <chinglinyu@google.com>,
Nadav Amit <namit@vmware.com>,
Srivatsa Bhat <srivatsab@vmware.com>,
"srivatsa@csail.mit.edu" <srivatsa@csail.mit.edu>,
Alexey Makhalov <amakhalov@vmware.com>,
Vasavi Sirnapalli <vsirnapalli@vmware.com>,
Tapas Kundu <tkundu@vmware.com>,
"er.ajay.kaher@gmail.com" <er.ajay.kaher@gmail.com>
Subject: Re: [PATCH v2 8/9] eventfs: moving tracing/events to eventfs
Date: Tue, 9 May 2023 12:29:23 +0000 [thread overview]
Message-ID: <1CAC8265-A4F3-4AF6-80E4-8F264ED670A9@vmware.com> (raw)
In-Reply-To: <202305030116.Gu6yyvKj-lkp@intel.com>
> On 02/05/23, 11:42 PM, "kernel test robot" <lkp@intel.com> wrote:
> >> kernel/trace/trace_events.c:2424:17: warning: variable 'd_events' set but not used [-Wunused-but-set-variable]
> struct dentry *d_events;
> ^
> 1 warning generated.
>
Steve, with-in event_create_dir(), do we have any scenario when file->event_call->class->system
doesn't have TRACE_SYSTEM? And need to execute following:
ae63b31e4d0e2e Steven Rostedt 2012-05-03 2437 d_events = parent;
looking for your input if we could remove d_events from event_create_dir().
- Ajay
> vim +/d_events +2424 kernel/trace/trace_events.c
>
> ac343da7bc9048 Masami Hiramatsu 2020-09-10 2417
> 1473e4417c79f1 Steven Rostedt 2009-02-24 2418 static int
> 7f1d2f8210195c Steven Rostedt (Red Hat 2015-05-05 2419) event_create_dir(struct dentry *parent, struct trace_event_file *file)
> 1473e4417c79f1 Steven Rostedt 2009-02-24 2420 {
> 2425bcb9240f8c Steven Rostedt (Red Hat 2015-05-05 2421) struct trace_event_call *call = file->event_call;
> ae63b31e4d0e2e Steven Rostedt 2012-05-03 2422 struct trace_array *tr = file->tr;
> 2fe2002efb23a7 Ajay Kaher 2023-05-02 2423 struct eventfs_file *ef_subsystem = NULL;
> ae63b31e4d0e2e Steven Rostedt 2012-05-03 @2424 struct dentry *d_events;
> de7b2973903c6c Mathieu Desnoyers 2014-04-08 2425 const char *name;
> fd99498989f3b3 Steven Rostedt 2009-02-28 2426 int ret;
> 1473e4417c79f1 Steven Rostedt 2009-02-24 2427
> 6ecc2d1ca39177 Steven Rostedt 2009-02-27 2428 /*
> 6ecc2d1ca39177 Steven Rostedt 2009-02-27 2429 * If the trace point header did not define TRACE_SYSTEM
> 6ecc2d1ca39177 Steven Rostedt 2009-02-27 2430 * then the system would be called "TRACE_SYSTEM".
> 6ecc2d1ca39177 Steven Rostedt 2009-02-27 2431 */
> ae63b31e4d0e2e Steven Rostedt 2012-05-03 2432 if (strcmp(call->class->system, TRACE_SYSTEM) != 0) {
> 2fe2002efb23a7 Ajay Kaher 2023-05-02 2433 ef_subsystem = event_subsystem_dir(tr, call->class->system, file, parent);
> 2fe2002efb23a7 Ajay Kaher 2023-05-02 2434 if (!ef_subsystem)
> ae63b31e4d0e2e Steven Rostedt 2012-05-03 2435 return -ENOMEM;
> ae63b31e4d0e2e Steven Rostedt 2012-05-03 2436 } else
> ae63b31e4d0e2e Steven Rostedt 2012-05-03 2437 d_events = parent;
> 6ecc2d1ca39177 Steven Rostedt 2009-02-27 2438
> 687fcc4aee4567 Steven Rostedt (Red Hat 2015-05-13 2439) name = trace_event_name(call);
> 2fe2002efb23a7 Ajay Kaher 2023-05-02 2440 file->ef = eventfs_add_dir(name, ef_subsystem, &tr->eventfs_rwsem);
> 2fe2002efb23a7 Ajay Kaher 2023-05-02 2441 if (IS_ERR(file->ef)) {
> 8434dc9340cd2e Steven Rostedt (Red Hat 2015-01-20 2442) pr_warn("Could not create tracefs '%s' directory\n", name);
> 1473e4417c79f1 Steven Rostedt 2009-02-24 2443 return -1;
> 1473e4417c79f1 Steven Rostedt 2009-02-24 2444 }
> 1473e4417c79f1 Steven Rostedt 2009-02-24 2445
> 9b63776fa3ca96 Steven Rostedt 2012-05-10 2446 if (call->class->reg && !(call->flags & TRACE_EVENT_FL_IGNORE_ENABLE))
> 2fe2002efb23a7 Ajay Kaher 2023-05-02 2447 eventfs_add_file("enable", TRACE_MODE_WRITE, file->ef, file,
> 620a30e97febc8 Oleg Nesterov 2013-07-31 2448 &ftrace_enable_fops);
> 1473e4417c79f1 Steven Rostedt 2009-02-24 2449
next prev parent reply other threads:[~2023-05-09 12:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 11:23 [PATCH v2 0/9] tracing: introducing eventfs Ajay Kaher
2023-05-02 11:23 ` [PATCH v2 1/9] eventfs: introducing struct tracefs_inode Ajay Kaher
2023-05-02 11:23 ` [PATCH v2 2/9] eventfs: adding eventfs dir add functions Ajay Kaher
2023-05-08 9:32 ` Zheng Yejian
2023-05-10 11:25 ` Ajay Kaher
2023-06-19 5:24 ` Ajay Kaher
2023-05-02 11:23 ` [PATCH v2 3/9] eventfs: adding eventfs file " Ajay Kaher
2023-05-02 11:23 ` [PATCH v2 4/9] eventfs: adding eventfs file, directory remove function Ajay Kaher
2023-05-02 14:21 ` kernel test robot
2023-05-02 16:04 ` kernel test robot
2023-05-02 22:15 ` kernel test robot
2023-05-02 11:23 ` [PATCH v2 5/9] eventfs: adding functions to create eventfs files and directories Ajay Kaher
2023-05-02 11:23 ` [PATCH v2 6/9] eventfs: adding eventfs lookup, read, open functions Ajay Kaher
2023-05-02 11:23 ` [PATCH v2 7/9] eventfs: creating tracefs_inode_cache Ajay Kaher
2023-05-02 11:23 ` [PATCH v2 8/9] eventfs: moving tracing/events to eventfs Ajay Kaher
2023-05-02 13:40 ` kernel test robot
2023-05-02 18:07 ` kernel test robot
2023-05-09 12:29 ` Ajay Kaher [this message]
2023-05-09 16:45 ` Steven Rostedt
2023-05-10 11:11 ` Ajay Kaher
2023-05-12 22:59 ` Steven Rostedt
2023-05-15 11:35 ` Ajay Kaher
2023-05-05 9:37 ` kernel test robot
2023-05-17 12:40 ` Ajay Kaher
2023-05-17 14:14 ` Steven Rostedt
2023-05-02 11:23 ` [PATCH v2 9/9] test: ftrace: fix kprobe test for eventfs Ajay Kaher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1CAC8265-A4F3-4AF6-80E4-8F264ED670A9@vmware.com \
--to=akaher@vmware.com \
--cc=amakhalov@vmware.com \
--cc=chinglinyu@google.com \
--cc=er.ajay.kaher@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=mhiramat@kernel.org \
--cc=namit@vmware.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=srivatsa@csail.mit.edu \
--cc=srivatsab@vmware.com \
--cc=tkundu@vmware.com \
--cc=vsirnapalli@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox