From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78396C38A2D for ; Mon, 24 Oct 2022 16:10:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232797AbiJXQKc (ORCPT ); Mon, 24 Oct 2022 12:10:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233344AbiJXQHe (ORCPT ); Mon, 24 Oct 2022 12:07:34 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BD949A9D9; Mon, 24 Oct 2022 07:59:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CD6A3B81132; Mon, 24 Oct 2022 14:58:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29E9FC433D7; Mon, 24 Oct 2022 14:58:02 +0000 (UTC) Date: Mon, 24 Oct 2022 10:58:12 -0400 From: Steven Rostedt To: "Masami Hiramatsu (Google)" Cc: LKML , Linux Trace Kernel Subject: Re: [PATCH] ring-buffer: Include dropped pages in counting dirty patches Message-ID: <20221024105812.4ae304b0@gandalf.local.home> In-Reply-To: <20221024221328.91994cb956fcb7effcbdb97d@kernel.org> References: <20221021123013.55fb6055@gandalf.local.home> <20221024221328.91994cb956fcb7effcbdb97d@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org On Mon, 24 Oct 2022 22:13:28 +0900 Masami Hiramatsu (Google) wrote: > > @@ -2020,6 +2029,7 @@ rb_remove_pages(struct ring_buffer_per_cpu *cpu_buffer, unsigned long nr_pages) > > */ > > local_add(page_entries, &cpu_buffer->overrun); > > local_sub(BUF_PAGE_SIZE, &cpu_buffer->entries_bytes); > > + local_inc(&cpu_buffer->pages_lost); > > Maybe we can make this part a static helper function so that we don't > repeat it below? Makes sense. I'll send a v2. -- Steve > > > } > > > > /* > > @@ -2504,6 +2514,7 @@ rb_handle_head_page(struct ring_buffer_per_cpu *cpu_buffer, > > */ > > local_add(entries, &cpu_buffer->overrun); > > local_sub(BUF_PAGE_SIZE, &cpu_buffer->entries_bytes); > > + local_inc(&cpu_buffer->pages_lost);