* [PATCH] tracing/eprobe: Fix eprobe filter to make a filter correctly
@ 2022-11-12 5:41 Masami Hiramatsu (Google)
2022-11-14 1:50 ` Masami Hiramatsu
2022-11-14 14:24 ` Rafael Mendonca
0 siblings, 2 replies; 4+ messages in thread
From: Masami Hiramatsu (Google) @ 2022-11-12 5:41 UTC (permalink / raw)
To: Linux Trace Kernel
Cc: Rafael Mendonca, Masami Hiramatsu, Steven Rostedt, LKML,
Tzvetomir Stoyanov
From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Since the eprobe filter was defined based on the eprobe's trace event
itself, it doesn't work correctly. Use the original trace event of
the eprobe when making the filter so that the filter works correctly.
Without this fix:
# echo 'e syscalls/sys_enter_openat \
flags_rename=$flags:u32 if flags < 1000' >> dynamic_events
# echo 1 > events/eprobes/sys_enter_openat/enable
[ 114.551550] event trace: Could not enable event sys_enter_openat
-bash: echo: write error: Invalid argument
With this fix:
# echo 'e syscalls/sys_enter_openat \
flags_rename=$flags:u32 if flags < 1000' >> dynamic_events
# echo 1 > events/eprobes/sys_enter_openat/enable
# tail trace
cat-241 [000] ...1. 266.498449: sys_enter_openat: (syscalls.sys_enter_openat) flags_rename=0
cat-242 [000] ...1. 266.977640: sys_enter_openat: (syscalls.sys_enter_openat) flags_rename=0
Fixes: 752be5c5c910 ("tracing/eprobe: Add eprobe filter support")
Reported-by: Rafael Mendonca <rafaelmendsr@gmail.com>
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
---
kernel/trace/trace_eprobe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace_eprobe.c b/kernel/trace/trace_eprobe.c
index fe4833a7b7b3..1c3096ab2fe7 100644
--- a/kernel/trace/trace_eprobe.c
+++ b/kernel/trace/trace_eprobe.c
@@ -643,7 +643,7 @@ new_eprobe_trigger(struct trace_eprobe *ep, struct trace_event_file *file)
INIT_LIST_HEAD(&trigger->list);
if (ep->filter_str) {
- ret = create_event_filter(file->tr, file->event_call,
+ ret = create_event_filter(file->tr, ep->event,
ep->filter_str, false, &filter);
if (ret)
goto error;
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] tracing/eprobe: Fix eprobe filter to make a filter correctly
2022-11-12 5:41 [PATCH] tracing/eprobe: Fix eprobe filter to make a filter correctly Masami Hiramatsu (Google)
@ 2022-11-14 1:50 ` Masami Hiramatsu
2022-11-14 14:24 ` Rafael Mendonca
1 sibling, 0 replies; 4+ messages in thread
From: Masami Hiramatsu @ 2022-11-14 1:50 UTC (permalink / raw)
To: Masami Hiramatsu (Google)
Cc: Linux Trace Kernel, Rafael Mendonca, Steven Rostedt, LKML,
Tzvetomir Stoyanov
Hi Rafael,
Can you give me your Tested-by on this?
Thank you,
On Sat, 12 Nov 2022 14:41:04 +0900
"Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
> From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> Since the eprobe filter was defined based on the eprobe's trace event
> itself, it doesn't work correctly. Use the original trace event of
> the eprobe when making the filter so that the filter works correctly.
>
> Without this fix:
>
> # echo 'e syscalls/sys_enter_openat \
> flags_rename=$flags:u32 if flags < 1000' >> dynamic_events
> # echo 1 > events/eprobes/sys_enter_openat/enable
> [ 114.551550] event trace: Could not enable event sys_enter_openat
> -bash: echo: write error: Invalid argument
>
> With this fix:
> # echo 'e syscalls/sys_enter_openat \
> flags_rename=$flags:u32 if flags < 1000' >> dynamic_events
> # echo 1 > events/eprobes/sys_enter_openat/enable
> # tail trace
> cat-241 [000] ...1. 266.498449: sys_enter_openat: (syscalls.sys_enter_openat) flags_rename=0
> cat-242 [000] ...1. 266.977640: sys_enter_openat: (syscalls.sys_enter_openat) flags_rename=0
>
> Fixes: 752be5c5c910 ("tracing/eprobe: Add eprobe filter support")
> Reported-by: Rafael Mendonca <rafaelmendsr@gmail.com>
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> ---
> kernel/trace/trace_eprobe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_eprobe.c b/kernel/trace/trace_eprobe.c
> index fe4833a7b7b3..1c3096ab2fe7 100644
> --- a/kernel/trace/trace_eprobe.c
> +++ b/kernel/trace/trace_eprobe.c
> @@ -643,7 +643,7 @@ new_eprobe_trigger(struct trace_eprobe *ep, struct trace_event_file *file)
> INIT_LIST_HEAD(&trigger->list);
>
> if (ep->filter_str) {
> - ret = create_event_filter(file->tr, file->event_call,
> + ret = create_event_filter(file->tr, ep->event,
> ep->filter_str, false, &filter);
> if (ret)
> goto error;
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] tracing/eprobe: Fix eprobe filter to make a filter correctly
2022-11-12 5:41 [PATCH] tracing/eprobe: Fix eprobe filter to make a filter correctly Masami Hiramatsu (Google)
2022-11-14 1:50 ` Masami Hiramatsu
@ 2022-11-14 14:24 ` Rafael Mendonca
2022-11-14 15:02 ` Masami Hiramatsu
1 sibling, 1 reply; 4+ messages in thread
From: Rafael Mendonca @ 2022-11-14 14:24 UTC (permalink / raw)
To: Masami Hiramatsu (Google)
Cc: Linux Trace Kernel, Steven Rostedt, LKML, Tzvetomir Stoyanov
On Sat, Nov 12, 2022 at 02:41:04PM +0900, Masami Hiramatsu (Google) wrote:
> From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> Since the eprobe filter was defined based on the eprobe's trace event
> itself, it doesn't work correctly. Use the original trace event of
> the eprobe when making the filter so that the filter works correctly.
>
> Without this fix:
>
> # echo 'e syscalls/sys_enter_openat \
> flags_rename=$flags:u32 if flags < 1000' >> dynamic_events
> # echo 1 > events/eprobes/sys_enter_openat/enable
> [ 114.551550] event trace: Could not enable event sys_enter_openat
> -bash: echo: write error: Invalid argument
>
> With this fix:
> # echo 'e syscalls/sys_enter_openat \
> flags_rename=$flags:u32 if flags < 1000' >> dynamic_events
> # echo 1 > events/eprobes/sys_enter_openat/enable
> # tail trace
> cat-241 [000] ...1. 266.498449: sys_enter_openat: (syscalls.sys_enter_openat) flags_rename=0
> cat-242 [000] ...1. 266.977640: sys_enter_openat: (syscalls.sys_enter_openat) flags_rename=0
>
> Fixes: 752be5c5c910 ("tracing/eprobe: Add eprobe filter support")
> Reported-by: Rafael Mendonca <rafaelmendsr@gmail.com>
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> ---
> kernel/trace/trace_eprobe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Hi Masami,
Tested this on top of v6.1-rc5 and the event filtering seems to be
working fine now. Tested with multiple events and conditions. Thanks.
Tested-by: Rafael Mendonca <rafaelmendsr@gmail.com>
>
> diff --git a/kernel/trace/trace_eprobe.c b/kernel/trace/trace_eprobe.c
> index fe4833a7b7b3..1c3096ab2fe7 100644
> --- a/kernel/trace/trace_eprobe.c
> +++ b/kernel/trace/trace_eprobe.c
> @@ -643,7 +643,7 @@ new_eprobe_trigger(struct trace_eprobe *ep, struct trace_event_file *file)
> INIT_LIST_HEAD(&trigger->list);
>
> if (ep->filter_str) {
> - ret = create_event_filter(file->tr, file->event_call,
> + ret = create_event_filter(file->tr, ep->event,
> ep->filter_str, false, &filter);
> if (ret)
> goto error;
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] tracing/eprobe: Fix eprobe filter to make a filter correctly
2022-11-14 14:24 ` Rafael Mendonca
@ 2022-11-14 15:02 ` Masami Hiramatsu
0 siblings, 0 replies; 4+ messages in thread
From: Masami Hiramatsu @ 2022-11-14 15:02 UTC (permalink / raw)
To: Rafael Mendonca
Cc: Linux Trace Kernel, Steven Rostedt, LKML, Tzvetomir Stoyanov
On Mon, 14 Nov 2022 11:24:32 -0300
Rafael Mendonca <rafaelmendsr@gmail.com> wrote:
> On Sat, Nov 12, 2022 at 02:41:04PM +0900, Masami Hiramatsu (Google) wrote:
> > From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> >
> > Since the eprobe filter was defined based on the eprobe's trace event
> > itself, it doesn't work correctly. Use the original trace event of
> > the eprobe when making the filter so that the filter works correctly.
> >
> > Without this fix:
> >
> > # echo 'e syscalls/sys_enter_openat \
> > flags_rename=$flags:u32 if flags < 1000' >> dynamic_events
> > # echo 1 > events/eprobes/sys_enter_openat/enable
> > [ 114.551550] event trace: Could not enable event sys_enter_openat
> > -bash: echo: write error: Invalid argument
> >
> > With this fix:
> > # echo 'e syscalls/sys_enter_openat \
> > flags_rename=$flags:u32 if flags < 1000' >> dynamic_events
> > # echo 1 > events/eprobes/sys_enter_openat/enable
> > # tail trace
> > cat-241 [000] ...1. 266.498449: sys_enter_openat: (syscalls.sys_enter_openat) flags_rename=0
> > cat-242 [000] ...1. 266.977640: sys_enter_openat: (syscalls.sys_enter_openat) flags_rename=0
> >
> > Fixes: 752be5c5c910 ("tracing/eprobe: Add eprobe filter support")
> > Reported-by: Rafael Mendonca <rafaelmendsr@gmail.com>
> > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> > ---
> > kernel/trace/trace_eprobe.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Hi Masami,
>
> Tested this on top of v6.1-rc5 and the event filtering seems to be
> working fine now. Tested with multiple events and conditions. Thanks.
>
> Tested-by: Rafael Mendonca <rafaelmendsr@gmail.com>
Thanks a lot!
>
> >
> > diff --git a/kernel/trace/trace_eprobe.c b/kernel/trace/trace_eprobe.c
> > index fe4833a7b7b3..1c3096ab2fe7 100644
> > --- a/kernel/trace/trace_eprobe.c
> > +++ b/kernel/trace/trace_eprobe.c
> > @@ -643,7 +643,7 @@ new_eprobe_trigger(struct trace_eprobe *ep, struct trace_event_file *file)
> > INIT_LIST_HEAD(&trigger->list);
> >
> > if (ep->filter_str) {
> > - ret = create_event_filter(file->tr, file->event_call,
> > + ret = create_event_filter(file->tr, ep->event,
> > ep->filter_str, false, &filter);
> > if (ret)
> > goto error;
> >
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-14 15:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-12 5:41 [PATCH] tracing/eprobe: Fix eprobe filter to make a filter correctly Masami Hiramatsu (Google)
2022-11-14 1:50 ` Masami Hiramatsu
2022-11-14 14:24 ` Rafael Mendonca
2022-11-14 15:02 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).