From: Steven Rostedt <rostedt@goodmis.org>
To: Ross Zwisler <zwisler@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
paulmck@kernel.org, Joel Fernandes <joel@joelfernandes.org>,
Tom Zanussi <zanussi@kernel.org>
Subject: Re: [PATCH v2] tracing: Add trace_trigger kernel command line option
Date: Thu, 8 Dec 2022 18:39:45 -0500 [thread overview]
Message-ID: <20221208183945.1de18843@gandalf.local.home> (raw)
In-Reply-To: <CAGRrVHw2ABuBtb+6BtES0WPNpbtu3p6vfZ-pADjtYYxm9kWZ4g@mail.gmail.com>
On Thu, 8 Dec 2022 15:27:07 -0700
Ross Zwisler <zwisler@google.com> wrote:
> > +#ifdef CONFIG_HIST_TRIGGERS
>
> Can you help me understand why this is only available if
> CONFIG_HIST_TRIGGERS is selected in the kernel config? AFAICT this
> code doesn't depend on the histogram code, and the run-time selection
> of triggers is usable without CONFIG_HIST_TRIGGERS.
Good catch!
I got confused, and only saw that as "CONFIG_TRIGGERS" and wasn't thinking
that config was just for histogram triggers :-p
Care to send a patch to fix it?
Thanks Ross,
-- Steve
next prev parent reply other threads:[~2022-12-08 23:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 1:00 [PATCH v2] tracing: Add trace_trigger kernel command line option Steven Rostedt
2022-12-08 22:27 ` Ross Zwisler
2022-12-08 23:39 ` Steven Rostedt [this message]
2022-12-09 0:19 ` Ross Zwisler
2022-12-09 5:29 ` Steven Rostedt
2022-12-09 0:33 ` [PATCH] tracing: remove unnecessary trace_trigger ifdef Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221208183945.1de18843@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=paulmck@kernel.org \
--cc=zanussi@kernel.org \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).