From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] tracing: Do not synchronize freeing of trigger filter on boot up
Date: Tue, 13 Dec 2022 17:24:29 -0500 [thread overview]
Message-ID: <20221213172429.7774f4ba@gandalf.local.home> (raw)
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
If a trigger filter on the kernel command line fails to apply (due to
syntax error), it will be freed. The freeing will call
tracepoint_synchronize_unregister(), but this is not needed during early
boot up, and will even trigger a lockdep splat.
Avoid calling the synchronization function when system_state is
SYSTEM_BOOTING.
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
kernel/trace/trace_events_trigger.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/trace_events_trigger.c b/kernel/trace/trace_events_trigger.c
index 19ce9d22bfd7..e535959939d3 100644
--- a/kernel/trace/trace_events_trigger.c
+++ b/kernel/trace/trace_events_trigger.c
@@ -1085,8 +1085,14 @@ int set_trigger_filter(char *filter_str,
rcu_assign_pointer(data->filter, filter);
if (tmp) {
- /* Make sure the call is done with the filter */
- tracepoint_synchronize_unregister();
+ /*
+ * Make sure the call is done with the filter.
+ * It is possible that a filter could fail at boot up,
+ * and then this path will be called. Avoid the synchronization
+ * in that case.
+ */
+ if (system_state != SYSTEM_BOOTING)
+ tracepoint_synchronize_unregister();
free_event_filter(tmp);
}
--
2.35.1
next reply other threads:[~2022-12-13 22:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 22:24 Steven Rostedt [this message]
2022-12-13 23:49 ` [PATCH] tracing: Do not synchronize freeing of trigger filter on boot up Masami Hiramatsu
2022-12-14 0:03 ` Steven Rostedt
2022-12-14 7:31 ` Masami Hiramatsu
2022-12-14 20:03 ` Paul E. McKenney
2022-12-14 20:37 ` Mathieu Desnoyers
2022-12-14 21:26 ` Paul E. McKenney
2022-12-15 15:02 ` Steven Rostedt
2022-12-15 17:02 ` Paul E. McKenney
2022-12-15 17:25 ` Paul E. McKenney
2022-12-15 18:51 ` Steven Rostedt
2022-12-15 19:01 ` Paul E. McKenney
2022-12-15 22:39 ` Steven Rostedt
2022-12-15 23:10 ` Paul E. McKenney
2022-12-15 23:42 ` Steven Rostedt
2022-12-16 1:01 ` Paul E. McKenney
2022-12-16 4:40 ` Paul E. McKenney
2022-12-16 11:08 ` Steven Rostedt
2022-12-18 0:29 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221213172429.7774f4ba@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).