From: Steven Rostedt <rostedt@goodmis.org>
To: Joel Fernandes <joel@joelfernandes.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Brian Norris <briannorris@chromium.org>,
Ross Zwisler <zwisler@google.com>,
Ching-lin Yu <chinglinyu@google.com>
Subject: Re: [RFC][PATCH] ACPI: tracing: Have ACPI debug go to tracing ring buffer
Date: Thu, 15 Dec 2022 14:11:46 -0500 [thread overview]
Message-ID: <20221215141146.6ceb7cf2@gandalf.local.home> (raw)
In-Reply-To: <Y5trUep9IvCv1Uwy@google.com>
On Thu, 15 Dec 2022 18:45:37 +0000
Joel Fernandes <joel@joelfernandes.org> wrote:
> Wouldn't it be better to also check trace_acpi_print_enabled() here in the
> else if() condition, along with IS_ENABLED()? That way if the CONFIG is
> enabled but the tracepoint is not enabled, at least the messages will go to
> dmesg instead of skipped.
I really don't want that. This was purposely done to be mutually exclusive.
The reason I added this in the first place, is because too much enabled
will render the system useless if printk() is used.
After boot up, if I had enabled all debug events and then I were to disable
the acpi tracepoint, it will likely render the system useless again if it
were to switch over to printk.
-- Steve
next prev parent reply other threads:[~2022-12-15 19:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 4:31 [RFC][PATCH] ACPI: tracing: Have ACPI debug go to tracing ring buffer Steven Rostedt
2022-12-15 18:45 ` Joel Fernandes
2022-12-15 19:11 ` Steven Rostedt [this message]
2022-12-15 19:52 ` Joel Fernandes
2022-12-15 20:13 ` Steven Rostedt
2022-12-30 15:52 ` Rafael J. Wysocki
2023-01-04 21:39 ` Steven Rostedt
2023-01-05 14:55 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221215141146.6ceb7cf2@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=briannorris@chromium.org \
--cc=chinglinyu@google.com \
--cc=joel@joelfernandes.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rafael@kernel.org \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).