From: Steven Rostedt <rostedt@goodmis.org>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Ross Zwisler <zwisler@google.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tom Zanussi <zanussi@kernel.org>,
Zheng Yejian <zhengyejian1@huawei.com>,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 2/2] tracing/selftests: Add test for event filtering on function name
Date: Mon, 19 Dec 2022 20:21:43 -0500 [thread overview]
Message-ID: <20221219202143.7fd28ac7@gandalf.local.home> (raw)
In-Reply-To: <a854db66-0a14-e40b-f3f0-369228fcd835@linuxfoundation.org>
On Mon, 19 Dec 2022 17:20:39 -0700
Shuah Khan <skhan@linuxfoundation.org> wrote:
> On 12/19/22 15:35, Steven Rostedt wrote:
> > On Mon, 19 Dec 2022 15:11:39 -0700
> > Shuah Khan <skhan@linuxfoundation.org> wrote:
> >
> >> On 12/19/22 13:57, Ross Zwisler wrote:
> >>> On Mon, Dec 19, 2022 at 01:31:08PM -0500, Steven Rostedt wrote:
> >>>> From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
> >>>>
> >>>> With the new filter logic of passing in the name of a function to match an
> >>>> instruction pointer (or the address of the function), add a test to make
> >>>> sure that it is functional.
> >>>>
> >>>> This is also the first test to test plain filtering. The filtering has
> >>>> been tested via the trigger logic, which uses the same code, but there was
> >>>> nothing to test just the event filter, so this test is the first to add
> >>>> such a case.
> >>>>
> >>>> Cc: Shuah Khan <shuah@kernel.org>
> >>>> Cc: Shuah Khan <skhan@linuxfoundation.org>
> >>>> Cc: linux-kselftest@vger.kernel.org
> >>>> Suggested-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> >>>> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> >>>
> >>> Reviewed-by: Ross Zwisler <zwisler@google.com>
> >>
> >> Thank you both. I will apply this after rc1 comes out.
> >
> > It's dependent on the first patch.
> >
>
> In which case,
>
> Acked-by: Shuah Khan <skhan@linuxfoundation.org>
>
Thanks Shuah!
-- Steve
prev parent reply other threads:[~2022-12-20 1:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 18:31 [PATCH 0/2] tracing: Add a way to filter function addresses to function names Steven Rostedt
2022-12-19 18:31 ` [PATCH 1/2] " Steven Rostedt
2022-12-19 20:57 ` Ross Zwisler
2022-12-19 18:31 ` [PATCH 2/2] tracing/selftests: Add test for event filtering on function name Steven Rostedt
2022-12-19 20:57 ` Ross Zwisler
2022-12-19 22:11 ` Shuah Khan
2022-12-19 22:35 ` Steven Rostedt
2022-12-20 0:20 ` Shuah Khan
2022-12-20 1:21 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221219202143.7fd28ac7@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=zanussi@kernel.org \
--cc=zhengyejian1@huawei.com \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).