From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05070C4708D for ; Tue, 20 Dec 2022 01:25:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232901AbiLTBYu (ORCPT ); Mon, 19 Dec 2022 20:24:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233173AbiLTBWh (ORCPT ); Mon, 19 Dec 2022 20:22:37 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA685E0C3; Mon, 19 Dec 2022 17:21:49 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 99887B80F9B; Tue, 20 Dec 2022 01:21:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43EABC433F0; Tue, 20 Dec 2022 01:21:46 +0000 (UTC) Date: Mon, 19 Dec 2022 20:21:43 -0500 From: Steven Rostedt To: Shuah Khan Cc: Ross Zwisler , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Masami Hiramatsu , Andrew Morton , Tom Zanussi , Zheng Yejian , Shuah Khan , linux-kselftest@vger.kernel.org Subject: Re: [PATCH 2/2] tracing/selftests: Add test for event filtering on function name Message-ID: <20221219202143.7fd28ac7@gandalf.local.home> In-Reply-To: References: <20221219183106.518341498@goodmis.org> <20221219183214.075559302@goodmis.org> <5e3e9408-8ddd-3649-ef98-4bd611c528cc@linuxfoundation.org> <20221219173507.410915a3@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org On Mon, 19 Dec 2022 17:20:39 -0700 Shuah Khan wrote: > On 12/19/22 15:35, Steven Rostedt wrote: > > On Mon, 19 Dec 2022 15:11:39 -0700 > > Shuah Khan wrote: > > > >> On 12/19/22 13:57, Ross Zwisler wrote: > >>> On Mon, Dec 19, 2022 at 01:31:08PM -0500, Steven Rostedt wrote: > >>>> From: "Steven Rostedt (Google)" > >>>> > >>>> With the new filter logic of passing in the name of a function to match an > >>>> instruction pointer (or the address of the function), add a test to make > >>>> sure that it is functional. > >>>> > >>>> This is also the first test to test plain filtering. The filtering has > >>>> been tested via the trigger logic, which uses the same code, but there was > >>>> nothing to test just the event filter, so this test is the first to add > >>>> such a case. > >>>> > >>>> Cc: Shuah Khan > >>>> Cc: Shuah Khan > >>>> Cc: linux-kselftest@vger.kernel.org > >>>> Suggested-by: Masami Hiramatsu (Google) > >>>> Signed-off-by: Steven Rostedt (Google) > >>> > >>> Reviewed-by: Ross Zwisler > >> > >> Thank you both. I will apply this after rc1 comes out. > > > > It's dependent on the first patch. > > > > In which case, > > Acked-by: Shuah Khan > Thanks Shuah! -- Steve