From: Quanfa Fu <quanfafu@gmail.com>
To: rostedt@goodmis.org, mhiramat@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Quanfa Fu <quanfafu@gmail.com>
Subject: [PATCH] tracing/eprobe: Replace kzalloc with kmalloc
Date: Sat, 7 Jan 2023 11:45:57 +0800 [thread overview]
Message-ID: <20230107034557.1156022-1-quanfafu@gmail.com> (raw)
Since this memory will be filled soon below, I feel that there is
no need for a memory of all zeros here. 'snprintf' does not return
negative num according to ISO C99, so I feel that no judgment is
needed here.
No functional change intended.
Signed-off-by: Quanfa Fu <quanfafu@gmail.com>
---
kernel/trace/trace_eprobe.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kernel/trace/trace_eprobe.c b/kernel/trace/trace_eprobe.c
index 352b65e2b910..cd1d271a74e7 100644
--- a/kernel/trace/trace_eprobe.c
+++ b/kernel/trace/trace_eprobe.c
@@ -917,15 +917,13 @@ static int trace_eprobe_parse_filter(struct trace_eprobe *ep, int argc, const ch
for (i = 0; i < argc; i++)
len += strlen(argv[i]) + 1;
- ep->filter_str = kzalloc(len, GFP_KERNEL);
+ ep->filter_str = kmalloc(len, GFP_KERNEL);
if (!ep->filter_str)
return -ENOMEM;
p = ep->filter_str;
for (i = 0; i < argc; i++) {
ret = snprintf(p, len, "%s ", argv[i]);
- if (ret < 0)
- goto error;
if (ret > len) {
ret = -E2BIG;
goto error;
--
2.31.1
next reply other threads:[~2023-01-07 3:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-07 3:45 Quanfa Fu [this message]
2023-01-07 8:42 ` [PATCH] tracing/eprobe: Replace kzalloc with kmalloc Christophe JAILLET
2023-01-07 12:20 ` Quanfa Fu
2023-01-07 12:23 ` Quanfa Fu
2023-01-07 14:08 ` Christophe JAILLET
2023-01-07 16:01 ` Masami Hiramatsu
2023-01-08 21:26 ` Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2023-01-07 3:43 Quanfa Fu
2023-01-08 21:22 ` Steven Rostedt
2023-01-09 3:44 ` Quanfa Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230107034557.1156022-1-quanfafu@gmail.com \
--to=quanfafu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).