From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Quanfa Fu <quanfafu@gmail.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v3] tracing/eprobe: no need to check for negative ret value for snprintf
Date: Mon, 9 Jan 2023 10:12:26 -0500 [thread overview]
Message-ID: <20230109101226.7f75fc0e@gandalf.local.home> (raw)
In-Reply-To: <20230109235913.8ac99d54cff8b7c3fc5dcfa4@kernel.org>
On Mon, 9 Jan 2023 23:59:13 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> On Mon, 9 Jan 2023 12:06:25 +0800
> Quanfa Fu <quanfafu@gmail.com> wrote:
>
> > No need to check for negative return value from snprintf() as the
> > code does not return negative values.
> >
>
> Thanks for simplifying, this looks good to me.
>
> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Masami, do you want to take it into the probes branch, or do you want me to
take it into the tracing branch?
-- Steve
>
> > Signed-off-by: Quanfa Fu <quanfafu@gmail.com>
> >
next prev parent reply other threads:[~2023-01-09 15:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 4:06 [PATCH v3] tracing/eprobe: no need to check for negative ret value for snprintf Quanfa Fu
2023-01-09 14:59 ` Masami Hiramatsu
2023-01-09 15:12 ` Steven Rostedt [this message]
2023-01-10 0:29 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230109101226.7f75fc0e@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=quanfafu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).